Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the rule which is the cause of blocked request #1458

Closed
zc-devs opened this issue Apr 22, 2024 · 3 comments · May be fixed by #1489
Closed

Show the rule which is the cause of blocked request #1458

zc-devs opened this issue Apr 22, 2024 · 3 comments · May be fixed by #1489
Labels
🔨 enhancement New feature or request Stale

Comments

@zc-devs
Copy link
Contributor

zc-devs commented Apr 22, 2024 •
edited
Loading

Recently I've added a few converted AGH lists to Blocky (v0.23) and hub.docker.com started to being blocked.

I have blocking request BLOCKED CNAME (ads), but there is no link to the rule, which is the cause. I had to bisect my lists. It was dandelion_sprouts_anti_malware_list. But it doesn't contain docker, dckr, elb.us-east-1.amazonaws.com.

It would be great if the rule is showed in the logs:

DEBUG blacklist_resolver: blocking request 'BLOCKED CNAME (ads: *.docler.com)'
INFO queryLog: query resolved ... question_name=hub.docker.com. question_type=A response_code=NXDOMAIN response_reason=BLOCKED CNAME (ads) block_rule=*.docler.com response_type=BLOCKED

or even point to the list and rule number:

DEBUG blacklist_resolver: blocking request 'BLOCKED CNAME (ads: anti_malware_list:100500)'
INFO queryLog: query resolved ... question_name=hub.docker.com. question_type=A response_code=NXDOMAIN response_reason=BLOCKED CNAME (ads) block_rule=anti_malware_list:100500 response_type=BLOCKED

hub.docker.com-blocky.log

Problem are getting worse, if we use a bunch of regex rules, I think.

Searched how lists are processed, found #558. So, this is duplicate and probably should be closed.
@kwitsch kwitsch added the 🔨 enhancement New feature or request label Apr 22, 2024
@kwitsch
Copy link
Collaborator

kwitsch commented Apr 22, 2024

It's not a full duplicate since you requested the rule which is way easier to achieve than the list or line number since those relations are currently not preserved during aggregation.

@zc-devs zc-devs mentioned this issue Apr 23, 2024
Merged
@zc-devs zc-devs mentioned this issue May 21, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jul 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔨 enhancement New feature or request Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Log blocking rule in resolver zc-devs/blocky
2 participants
@kwitsch @zc-devs