Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sequencer/RPC] - unwind feature not working fully #807

Closed
hexoscott opened this issue Jul 17, 2024 · 6 comments
Closed

[Sequencer/RPC] - unwind feature not working fully #807

hexoscott opened this issue Jul 17, 2024 · 6 comments
Assignees
Labels
Critical required for release Gateway FM

Comments

@hexoscott
Copy link
Collaborator

When using the unwind tool at ./cmd/integration the node looks like it has unwound to the correct height but upon starting the node again too many blocks have been removed. Having this feature fully working would be a huge help during L1 recovery as you wouldn't need to sync a node from scratch up to the broken batch point, which is typically very close to the tip anyway.

@Sharonbc01
Copy link

Hey @V-Staykov any update on this issue? Can it be addressed by Aug-09 when we plan to build image for sequencer to deploy to Cardona on Aug-12.

@hexoscott
Copy link
Collaborator Author

A quick update on this one, the process appears to be working fine for RPC and sequencer for a simple network, but there are some changes coming as part of other work to handle the unwind of the L1 info tree index which will be crucial for this to be considered complete. Once we have that we will be able to test some more complex scenarios and ensure things are working as expected.

@Sharonbc01
Copy link

Thanks @hexoscott for update.
As noted above this is a requirement from Edu so can this changes coming as part of other work to handle the unwind of the L1 info tree index which will be crucial for this to be considered complete. Do you have an ETA on these?

I will highlight to @mandrigin at next status update WRT to the target date of Aug-12

@hexoscott
Copy link
Collaborator Author

We are aiming to merge in the block by block changes, which include these unwind changes around the info tree, today or tomorrow. After that we can start testing some more complex unwind scenarios and go from there with any findings we make.

@Sharonbc01
Copy link

Thanks @hexoscott for getting Executor block by block #909 is merged. Hoping this one can closed soon now you can do more testing with at a block level for unwinds. Thanks

@Sharonbc01 Sharonbc01 added Critical required for release Gateway FM labels Aug 12, 2024
@mandrigin
Copy link
Collaborator

fixed by #936

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical required for release Gateway FM
Projects
None yet
Development

No branches or pull requests

4 participants