Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve e2e group 8 (RPC debug_trace) to reduce the failing rate #2760

Closed
joanestebanr opened this issue Nov 8, 2023 · 2 comments · Fixed by #2761
Closed

Improve e2e group 8 (RPC debug_trace) to reduce the failing rate #2760

joanestebanr opened this issue Nov 8, 2023 · 2 comments · Fixed by #2761

Comments

@joanestebanr
Copy link
Contributor

joanestebanr commented Nov 8, 2023

Rationale

The highest rate of false failing of the e2e groups are:

group 10: 42%: already fixed #2748
group 8: 12%
group 9: 10%
group 5: 10%
So, the next most important is group is 8 (RPC debug_trace)

There are 6 fails in the total of 12 PR analized:

What cause the error?

runtime error: index out of range [1] with length 1 [recovered]

023-10-26T15:03:39.458Z	DEBUG	e2e-group8/debug_calltracer_test.go:374	tx sent: 0x5b01ecd1c4fd80b31c7e786bff45392a9b7a5c8599b046c6be8b4cdc08b5b836	{"pid": 24077, "version": "v0.1.0"}
2023-10-26T15:03:40.462Z	DEBUG	operations/wait.go:99	Transaction successfully mined: 0x5b01ecd1c4fd80b31c7e786bff45392a9b7a5c8599b046c6be8b4cdc08b5b836	{"pid": 24077, "version": "v0.1.0"}
--- FAIL: TestDebugTraceBlockCallTracer (69.28s)
    --- PASS: TestDebugTraceBlockCallTracer/eth_transfer_by_number (3.06s)
    --- PASS: TestDebugTraceBlockCallTracer/sc_deployment_by_number (3.06s)
    --- PASS: TestDebugTraceBlockCallTracer/sc_call_by_number (6.37s)
    --- PASS: TestDebugTraceBlockCallTracer/erc20_transfer_by_number (10.14s)
    --- PASS: TestDebugTraceBlockCallTracer/eth_transfer_by_hash (3.04s)
    --- FAIL: TestDebugTraceBlockCallTracer/sc_deployment_by_hash (3.06s)
panic: runtime error: index out of range [1] with length 1 [recovered]
	panic: runtime error: index out of range [1] with length 1

goroutine 2646 [running]:
testing.tRunner.func1.2({0x1dc57e0, 0xc00024cb70})
	/opt/hostedtoolcache/go/1.21.3/x64/src/testing/testing.go:1545 +0x366
testing.tRunner.func1()
	/opt/hostedtoolcache/go/1.21.3/x64/src/testing/testing.go:1548 +0x630
panic({0x1dc57e0?, 0xc00024cb70?})
	/opt/hostedtoolcache/go/1.21.3/x64/src/runtime/panic.go:[920](https://github.com/0xPolygonHermez/zkevm-node/actions/runs/6655517721/job/18087108962#step:6:921) +0x270
github.com/0xPolygonHermez/zkevm-node/ci/e2e-group8.TestDebugTraceBlockCallTracer.func3(0x0?)
	/home/runner/work/zkevm-node/zkevm-node/ci/e2e-group8/debug_calltracer_test.go:420 +0x1285
testing.tRunner(0xc000303520, 0xc00062c780)
	/opt/hostedtoolcache/go/1.21.3/x64/src/testing/testing.go:1595 +0x239
created by testing.(*T).Run in goroutine 1298
	/opt/hostedtoolcache/go/1.21.3/x64/src/testing/testing.go:1648 +0x82b
FAIL	github.com/0xPolygonHermez/zkevm-node/ci/e2e-group8	419.300s
FAIL

executor/client.go:47 fail to dial: context deadline exceeded

2023-10-30T08:54:15.942Z	FATAL	executor/client.go:47	fail to dial: context deadline exceeded%!(EXTRA string=
/home/runner/work/zkevm-node/zkevm-node/log/log.go:140 github.com/0xPolygonHermez/zkevm-node/log.appendStackTraceMaybeArgs()
/home/runner/work/zkevm-node/zkevm-node/log/log.go:242 github.com/0xPolygonHermez/zkevm-node/log.Fatalf()
/home/runner/work/zkevm-node/zkevm-node/state/runtime/executor/client.go:47 github.com/0xPolygonHermez/zkevm-node/state/runtime/executor.NewExecutorClient()
/home/runner/work/zkevm-node/zkevm-node/test/operations/manager.go:467 github.com/0xPolygonHermez/zkevm-node/test/operations.initState()
/home/runner/work/zkevm-node/zkevm-node/test/operations/manager.go:103 github.com/0xPolygonHermez/zkevm-node/test/operations.NewManager()
/home/runner/work/zkevm-node/zkevm-node/ci/e2e-group8/debug_calltracer_test.go:43 github.com/0xPolygonHermez/zkevm-node/ci/e2e-group8.TestDebugTraceTransactionCallTracer()
/opt/hostedtoolcache/go/1.21.3/x64/src/testing/testing.go:1595 testing.tRunner()
)	{"pid": 24124, "version": "v0.1.0"}
github.com/0xPolygonHermez/zkevm-node/state/runtime/executor.NewExecutorClient
	/home/runner/work/zkevm-node/zkevm-node/state/runtime/executor/client.go:47
github.com/0xPolygonHermez/zkevm-node/test/operations.initState
	/home/runner/work/zkevm-node/zkevm-node/test/operations/manager.go:467
github.com/0xPolygonHermez/zkevm-node/test/operations.NewManager
	/home/runner/work/zkevm-node/zkevm-node/test/operations/manager.go:103
github.com/0xPolygonHermez/zkevm-node/ci/e2e-group8.TestDebugTraceTransactionCallTracer
	/home/runner/work/zkevm-node/zkevm-node/ci/e2e-group8/debug_calltracer_test.go:43
testing.tRunner
	/opt/hostedtoolcache/go/1.21.3/x64/src/testing/testing.go:1595
FAIL	github.com/0xPolygonHermez/zkevm-node/ci/e2e-group8	143.372s
FAIL
@joanestebanr
Copy link
Contributor Author

Sometimes a L1 block could contain more that one tx. In that case the test fails, now match the tx that we want to check in the response of debug_traceBlockByNumber or debug_traceBlockByHash

@lyh169
Copy link

lyh169 commented Nov 13, 2023

Hi, when fix the group 5 (RPC debug_trace), because the reason that group 5 and the group 8 run ci faild is same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants