Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a procedure for basic wallets that creates notes with 0 or more assets #800

Closed
tomyrd opened this issue Jul 17, 2024 · 1 comment
Closed

feat: add a procedure for basic wallets that creates notes with 0 or more assets #800

tomyrd opened this issue Jul 17, 2024 · 1 comment
Assignees
@Fumuran
Milestone
v0.5

Comments

@tomyrd
Copy link
Collaborator

tomyrd commented Jul 17, 2024 •
edited
Loading

The proper way to make this work is to add send_note procedure the BasicWallet interface. This would work similarly to the current send_asset but it would allow creating notes with 0 or more assets.

Originally posted by @bobbinth in 0xPolygonMiden/miden-client#438 (comment)
@tomyrd tomyrd changed the title I think this will create as many notes as there are notes * assets combinations. For now, I think we should assume that each note has only 1 asset and return an error otherwise (for faucets that should always be the case anyway). feat: add a procedure for basic wallets that creates notes with 0 or more assets Jul 17, 2024
@tomyrd tomyrd mentioned this issue Jul 17, 2024
Open
@bobbinth bobbinth added this to the v0.5 milestone Jul 17, 2024
@bobbinth bobbinth assigned Dominik1999 and Fumuran and unassigned Dominik1999 Jul 22, 2024
@Dominik1999 Dominik1999 moved this to In Progress in User's testnet Aug 5, 2024
@Fumuran
Copy link
Contributor

Fumuran commented Aug 9, 2024

Closed by #808.

@Fumuran Fumuran closed this as completed Aug 9, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in User's testnet Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fumuran Fumuran

Labels
None yet
Projects
User's testnet
Status: Done
Milestone
v0.5
Development

No branches or pull requests
4 participants
@Dominik1999 @Fumuran @tomyrd @bobbinth