Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make miden_lib::notes::build_swap_tag() public #806

Closed
igamigo opened this issue Jul 29, 2024 · 1 comment · Fixed by #817
Closed

Make miden_lib::notes::build_swap_tag() public #806

igamigo opened this issue Jul 29, 2024 · 1 comment · Fixed by #817
Assignees
Milestone

Comments

@igamigo
Copy link
Collaborator

igamigo commented Jul 29, 2024

What should be done?

Currently, this function is private which is unfortunate for projects like the client which could make use of it. As of now, the function is duplicated in the codebase but we could remove it if we made it usable from outside of miden-lib

How should it be done?

Making the function pub.

When is this task done?

When the function can be used from outside of miden-lib

Additional context

0xPolygonMiden/miden-client#437 (comment)

@bobbinth bobbinth added this to the v0.5 milestone Jul 29, 2024
@Dominik1999 Dominik1999 moved this to In Progress in User's testnet Aug 5, 2024
@Fumuran Fumuran linked a pull request Aug 5, 2024 that will close this issue
@Fumuran
Copy link
Contributor

Fumuran commented Aug 5, 2024

Closed by #817.

@Fumuran Fumuran closed this as completed Aug 5, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in User's testnet Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants