Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge update methods for InputNoteRecord in the Store #404

Closed
tomyrd opened this issue Jun 28, 2024 · 2 comments
Closed

Merge update methods for InputNoteRecord in the Store #404

tomyrd opened this issue Jun 28, 2024 · 2 comments
Milestone
v0.6.0

Comments

@tomyrd
Copy link
Collaborator

tomyrd commented Jun 28, 2024 •
edited
Loading

We should join update_note_inclusion_proof and update_note_metadata in the same method as they are always called in tandem.

Based on this comment
@tomyrd
Copy link
Collaborator Author

tomyrd commented Jun 28, 2024

As discussed in this comment maybe we should remove the update methods and change the insert_input_note to also work for updating the note record.

cc @igamigo @mFragaBA

@tomyrd
Copy link
Collaborator Author

tomyrd commented Oct 24, 2024

Addressed in #520 with the addition of upsert_input_note

@tomyrd tomyrd closed this as completed Oct 24, 2024
@bobbinth bobbinth added this to the v0.6.0 milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
User's testnet
Status: Done
Milestone
v0.6.0
Development

No branches or pull requests
2 participants
@tomyrd @bobbinth