Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for CHANGELOG changes on CI and specify targets on rust-toolchain.toml #452

Closed
igamigo opened this issue Jul 29, 2024 · 0 comments · Fixed by #456
Closed

Check for CHANGELOG changes on CI and specify targets on rust-toolchain.toml #452

igamigo opened this issue Jul 29, 2024 · 0 comments · Fixed by #456
Assignees
Milestone

Comments

@igamigo
Copy link
Collaborator

igamigo commented Jul 29, 2024

What should be done?

There are a couple of changes that we can do to improve the CI:

  • In order to correctly document changes, we can add CHANGELOG checks on the CI to make sure logs are pertinently added on each PR.
  • We can add Rust toolchain metadata on rust-toolchain.toml (example). I don't think this allows us to simplify CI (the current action does not honor it AFAIK), but it will make it easier to install manually.

How should it be done?

First point could be done similar to this implementation

When is this task done?

When we have a CI step that checks for changelog lines.

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants