Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add warning for no doc updates #587

Open
phklive opened this issue Dec 16, 2024 · 4 comments
Open

[Feature]: Add warning for no doc updates #587

phklive opened this issue Dec 16, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@phklive
Copy link
Contributor

phklive commented Dec 16, 2024

To whom is this feature for?

App developer

Why is is this feature needed?

To make sure that our docs are always up to date.

How is this feature used?

Follow the update that we have made for the changelog and adapt it for the doc updates: 0xPolygonMiden/miden-base#799

Make sure that each PR has a corresponding doc update if needed.

If not the PR should be flagged with no docs

Anything else?

No response

@phklive phklive added enhancement New feature or request good first issue Good for newcomers labels Dec 16, 2024
@Mirko-von-Leipzig
Copy link
Contributor

What sort of changes would require documentation updates?

@phklive
Copy link
Contributor Author

phklive commented Dec 17, 2024

What sort of changes would require documentation updates?

Everything that touches to something that is documented.

Ex. You have docs about the mempool, you change the mempool impl, you need to make sure to update the mempool docs

@Mirko-von-Leipzig
Copy link
Contributor

What sort of changes would require documentation updates?

Everything that touches to something that is documented.

Ex. You have docs about the mempool, you change the mempool impl, you need to make sure to update the mempool docs

But there are no mempool docs unless you mean comments in the code

@bobbinth
Copy link
Contributor

I think over time it would be good to have documentation that describes how mempool (and other components) work in a more of an "article" format and put these into an mdbook. For now, we don't really have this (and I'm not sure we need it for the immediate future).

But, I think we should have docs on how to start the node, monitor it (when this is implemented), maintain etc. We have some of this in Markdown files, but may make sense to transfer this to an mdBook format. Another thing that could go there is documentation on API endpoints (especially for the RPC component).

Basically, I think we should move most of the existing docs into the mdbook format, add RPC API docs to it, and then these docs would be subject to updates when we change things. The deeper architectural docs could come later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants