Update banking category #8364
Merged
Update banking category #8364
+48
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carlgo11
added
update site
|
Apparently Bankera is ranked >400K on SimilarWeb. Previously we haven't removed existing sites unless they've dropped substantially, but I leave that choice up to the reviewing maintainer. I'm fine with either leaving it in or removing the entry 🤷 |
hkamran80
requested changes
Jan 13, 2025
There was a problem hiding this comment.
Apparently Bankera is ranked >400K on SimilarWeb. Previously we haven't removed existing sites unless they've dropped substantially, but I leave that choice up to the reviewing maintainer. I'm fine with either leaving it in or removing the entry 🤷
I'm fine with keeping it in for now.
entries/b/bankera.com.json
Outdated
Comment on lines
11
to
17
| "regions": [ | ||
| "-us" | ||
| "-us", | ||
| "-kp", | ||
| "-ru", | ||
| "-ir", | ||
| "-by" | ||
| ] |
There was a problem hiding this comment.
Given that it gives users a European IBAN with SEPA payment support, should we restrict Bankera to EU regions?
Co-authored-by: H. Kamran <[email protected]> Signed-off-by: Carl <[email protected]>
hkamran80
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looked at the banking category and found some entries that needed to be updated.