Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If an entry RDN is identical to the suffix, then Entryrdn gets broken during a reindex #6417

Open
tbordaz opened this issue Nov 22, 2024 · 7 comments · Fixed by #6418 or #6460 · May be fixed by #6480
Open

If an entry RDN is identical to the suffix, then Entryrdn gets broken during a reindex #6417

tbordaz opened this issue Nov 22, 2024 · 7 comments · Fixed by #6418 or #6460 · May be fixed by #6480
Assignees
@tbordaz
Labels
priority_high need urgent fix / highly valuable / easy to fix
Milestone
1.4.3

Comments

@tbordaz
Copy link
Contributor

tbordaz commented Nov 22, 2024

Issue Description
At the end of a reindex, entryrdn is rebuilt taking into account each entry under the suffix. The suffix is the first entry to be added. If a later entry has the same rdn than the suffix then entryrdn gets broken.

The bug impacts bdb as well as mdb. It does not impact import but only indexing.

Under mdb entryrdn gets broken silently, but contains invalid data
Under bdb entryrdn gets broken with message like
entryrdn_insert_key - Same DN (dn: <ENTRY_DN>) is already in the entryrdn file with different ID

Package Version and Platform:

  • all versions (IIUC)

Steps to Reproduce
will provide a CI testcase

Expected results
after a reindex entryrdn should not be corrupted
@tbordaz tbordaz added the needs triage The issue will be triaged during scrum label Nov 22, 2024
tbordaz added a commit to tbordaz/389-ds-base that referenced this issue Nov 22, 2024
@tbordaz
Issue 6417 - If an entry RDN is identical to the suffix, then Entryrd…
0876f74 
…n gets broken during a reindex

Bug description:
	During a reindex, the entryrdn index is built at the end from
	each entry in the suffix.
	If one entry has a RDN that is identical to the suffix DN,
	then entryrdn_lookup_dn may erroneously return the suffix DN
	as the DN of the entry.

Fix description:
	When the lookup entry has no parent (because index is under
	work) the loop lookup the entry using the RDN.
	If this RDN matches the suffix DN, then it exits from the loop
	with the suffix DN.
	Before exiting it checks that the original lookup entryID
	is equal to suffix entryID. If it does not match
	the function fails and then the DN from the entry will be
	built from id2enty

fixes: 389ds#6417

Reviewed by:
@tbordaz tbordaz mentioned this issue Nov 22, 2024
Merged
tbordaz added a commit to tbordaz/389-ds-base that referenced this issue Nov 22, 2024
@tbordaz
Issue 6417 - If an entry RDN is identical to the suffix, then Entryrd…
87eaf73 
…n gets broken during a reindex

Bug description:
	During a reindex, the entryrdn index is built at the end from
	each entry in the suffix.
	If one entry has a RDN that is identical to the suffix DN,
	then entryrdn_lookup_dn may erroneously return the suffix DN
	as the DN of the entry.

Fix description:
	When the lookup entry has no parent (because index is under
	work) the loop lookup the entry using the RDN.
	If this RDN matches the suffix DN, then it exits from the loop
	with the suffix DN.
	Before exiting it checks that the original lookup entryID
	is equal to suffix entryID. If it does not match
	the function fails and then the DN from the entry will be
	built from id2enty

fixes: 389ds#6417

Reviewed by:
@tbordaz tbordaz self-assigned this Nov 22, 2024
@tbordaz tbordaz added this to the 1.4.3 milestone Nov 22, 2024
@tbordaz tbordaz added priority_high need urgent fix / highly valuable / easy to fix and removed needs triage The issue will be triaged during scrum labels Nov 22, 2024
tbordaz added a commit to tbordaz/389-ds-base that referenced this issue Nov 25, 2024
@tbordaz
Issue 6417 - If an entry RDN is identical to the suffix, then Entryrd…
06c2426 
…n gets broken during a reindex

Bug description:
        During a reindex, the entryrdn index is built at the end from
        each entry in the suffix.
        If one entry has a RDN that is identical to the suffix DN,
        then entryrdn_lookup_dn may erroneously return the suffix DN
        as the DN of the entry.

Fix description:
        When the lookup entry has no parent (because index is under
        work) the loop lookup the entry using the RDN.
        If this RDN matches the suffix DN, then it exits from the loop
        with the suffix DN.
        Before exiting it checks that the original lookup entryID
        is equal to suffix entryID. If it does not match
        the function fails and then the DN from the entry will be
        built from id2enty

fixes: 389ds#6417

Reviewed by: Pierre Rogier, Simon Pichugin (Thanks !!!)
tbordaz added a commit to tbordaz/389-ds-base that referenced this issue Nov 27, 2024
@tbordaz
Issue 6417 - If an entry RDN is identical to the suffix, then Entryrd…
a70357a 
…n gets broken during a reindex

Bug description:
        During a reindex, the entryrdn index is built at the end from
        each entry in the suffix.
        If one entry has a RDN that is identical to the suffix DN,
        then entryrdn_lookup_dn may erroneously return the suffix DN
        as the DN of the entry.

Fix description:
        When the lookup entry has no parent (because index is under
        work) the loop lookup the entry using the RDN.
        If this RDN matches the suffix DN, then it exits from the loop
        with the suffix DN.
        Before exiting it checks that the original lookup entryID
        is equal to suffix entryID. If it does not match
        the function fails and then the DN from the entry will be
        built from id2enty

fixes: 389ds#6417

Reviewed by: Pierre Rogier, Simon Pichugin (Thanks !!!)
tbordaz added a commit to tbordaz/389-ds-base that referenced this issue Nov 28, 2024
@tbordaz
Issue 6417 - If an entry RDN is identical to the suffix, then Entryrd…
5c8ee4f 
…n gets broken during a reindex

Bug description:
        During a reindex, the entryrdn index is built at the end from
        each entry in the suffix.
        If one entry has a RDN that is identical to the suffix DN,
        then entryrdn_lookup_dn may erroneously return the suffix DN
        as the DN of the entry.

Fix description:
        When the lookup entry has no parent (because index is under
        work) the loop lookup the entry using the RDN.
        If this RDN matches the suffix DN, then it exits from the loop
        with the suffix DN.
        Before exiting it checks that the original lookup entryID
        is equal to suffix entryID. If it does not match
        the function fails and then the DN from the entry will be
        built from id2enty

fixes: 389ds#6417

Reviewed by: Pierre Rogier, Simon Pichugin (Thanks !!!)
tbordaz added a commit to tbordaz/389-ds-base that referenced this issue Nov 29, 2024
@tbordaz
Issue 6417 - If an entry RDN is identical to the suffix, then Entryrd…
1359b0e 
…n gets broken during a reindex

Bug description:
        During a reindex, the entryrdn index is built at the end from
        each entry in the suffix.
        If one entry has a RDN that is identical to the suffix DN,
        then entryrdn_lookup_dn may erroneously return the suffix DN
        as the DN of the entry.

Fix description:
        When the lookup entry has no parent (because index is under
        work) the loop lookup the entry using the RDN.
        If this RDN matches the suffix DN, then it exits from the loop
        with the suffix DN.
        Before exiting it checks that the original lookup entryID
        is equal to suffix entryID. If it does not match
        the function fails and then the DN from the entry will be
        built from id2enty

fixes: 389ds#6417

Reviewed by: Pierre Rogier, Simon Pichugin (Thanks !!!)
tbordaz added a commit to tbordaz/389-ds-base that referenced this issue Dec 2, 2024
@tbordaz
Issue 6417 - If an entry RDN is identical to the suffix, then Entryrd…
52664a8 
…n gets broken during a reindex

Bug description:
        During a reindex, the entryrdn index is built at the end from
        each entry in the suffix.
        If one entry has a RDN that is identical to the suffix DN,
        then entryrdn_lookup_dn may erroneously return the suffix DN
        as the DN of the entry.

Fix description:
        When the lookup entry has no parent (because index is under
        work) the loop lookup the entry using the RDN.
        If this RDN matches the suffix DN, then it exits from the loop
        with the suffix DN.
        Before exiting it checks that the original lookup entryID
        is equal to suffix entryID. If it does not match
        the function fails and then the DN from the entry will be
        built from id2enty

fixes: 389ds#6417

Reviewed by: Pierre Rogier, Simon Pichugin (Thanks !!!)
tbordaz added a commit that referenced this issue Dec 2, 2024
@tbordaz
Issue 6417 - If an entry RDN is identical to the suffix, then Entryrd…
99e6707 
…n gets broken during a reindex (#6418)

Bug description:
        During a reindex, the entryrdn index is built at the end from
        each entry in the suffix.
        If one entry has a RDN that is identical to the suffix DN,
        then entryrdn_lookup_dn may erroneously return the suffix DN
        as the DN of the entry.

Fix description:
        When the lookup entry has no parent (because index is under
        work) the loop lookup the entry using the RDN.
        If this RDN matches the suffix DN, then it exits from the loop
        with the suffix DN.
        Before exiting it checks that the original lookup entryID
        is equal to suffix entryID. If it does not match
        the function fails and then the DN from the entry will be
        built from id2enty

fixes: #6417

Reviewed by: Pierre Rogier, Simon Pichugin (Thanks !!!)
tbordaz added a commit that referenced this issue Dec 2, 2024
@tbordaz
Issue 6417 - If an entry RDN is identical to the suffix, then Entryrd…
63000bf 
…n gets broken during a reindex (#6418)

Bug description:
        During a reindex, the entryrdn index is built at the end from
        each entry in the suffix.
        If one entry has a RDN that is identical to the suffix DN,
        then entryrdn_lookup_dn may erroneously return the suffix DN
        as the DN of the entry.

Fix description:
        When the lookup entry has no parent (because index is under
        work) the loop lookup the entry using the RDN.
        If this RDN matches the suffix DN, then it exits from the loop
        with the suffix DN.
        Before exiting it checks that the original lookup entryID
        is equal to suffix entryID. If it does not match
        the function fails and then the DN from the entry will be
        built from id2enty

fixes: #6417

Reviewed by: Pierre Rogier, Simon Pichugin (Thanks !!!)
tbordaz added a commit that referenced this issue Dec 2, 2024
@tbordaz
Issue 6417 - If an entry RDN is identical to the suffix, then Entryrd…
7acdd65 
…n gets broken during a reindex (#6418)

Bug description:
        During a reindex, the entryrdn index is built at the end from
        each entry in the suffix.
        If one entry has a RDN that is identical to the suffix DN,
        then entryrdn_lookup_dn may erroneously return the suffix DN
        as the DN of the entry.

Fix description:
        When the lookup entry has no parent (because index is under
        work) the loop lookup the entry using the RDN.
        If this RDN matches the suffix DN, then it exits from the loop
        with the suffix DN.
        Before exiting it checks that the original lookup entryID
        is equal to suffix entryID. If it does not match
        the function fails and then the DN from the entry will be
        built from id2enty

fixes: #6417

Reviewed by: Pierre Rogier, Simon Pichugin (Thanks !!!)
tbordaz added a commit that referenced this issue Dec 2, 2024
@tbordaz
Issue 6417 - If an entry RDN is identical to the suffix, then Entryrd…
bf8a8f3 
…n gets broken during a reindex (#6418)

Bug description:
        During a reindex, the entryrdn index is built at the end from
        each entry in the suffix.
        If one entry has a RDN that is identical to the suffix DN,
        then entryrdn_lookup_dn may erroneously return the suffix DN
        as the DN of the entry.

Fix description:
        When the lookup entry has no parent (because index is under
        work) the loop lookup the entry using the RDN.
        If this RDN matches the suffix DN, then it exits from the loop
        with the suffix DN.
        Before exiting it checks that the original lookup entryID
        is equal to suffix entryID. If it does not match
        the function fails and then the DN from the entry will be
        built from id2enty

fixes: #6417

Reviewed by: Pierre Rogier, Simon Pichugin (Thanks !!!)
tbordaz added a commit that referenced this issue Dec 2, 2024
@tbordaz
Issue 6417 - If an entry RDN is identical to the suffix, then Entryrd…
f42fdc1 
…n gets broken during a reindex (#6418)

Bug description:
        During a reindex, the entryrdn index is built at the end from
        each entry in the suffix.
        If one entry has a RDN that is identical to the suffix DN,
        then entryrdn_lookup_dn may erroneously return the suffix DN
        as the DN of the entry.

Fix description:
        When the lookup entry has no parent (because index is under
        work) the loop lookup the entry using the RDN.
        If this RDN matches the suffix DN, then it exits from the loop
        with the suffix DN.
        Before exiting it checks that the original lookup entryID
        is equal to suffix entryID. If it does not match
        the function fails and then the DN from the entry will be
        built from id2enty

fixes: #6417

Reviewed by: Pierre Rogier, Simon Pichugin (Thanks !!!)
tbordaz added a commit that referenced this issue Dec 2, 2024
@tbordaz
Issue 6417 - If an entry RDN is identical to the suffix, then Entryrd…
ccbb8ba 
…n gets broken during a reindex (#6418)

Bug description:
        During a reindex, the entryrdn index is built at the end from
        each entry in the suffix.
        If one entry has a RDN that is identical to the suffix DN,
        then entryrdn_lookup_dn may erroneously return the suffix DN
        as the DN of the entry.

Fix description:
        When the lookup entry has no parent (because index is under
        work) the loop lookup the entry using the RDN.
        If this RDN matches the suffix DN, then it exits from the loop
        with the suffix DN.
        Before exiting it checks that the original lookup entryID
        is equal to suffix entryID. If it does not match
        the function fails and then the DN from the entry will be
        built from id2enty

fixes: #6417

Reviewed by: Pierre Rogier, Simon Pichugin (Thanks !!!)
tbordaz added a commit that referenced this issue Dec 2, 2024
@tbordaz
Issue 6417 - If an entry RDN is identical to the suffix, then Entryrd…
37b4598 
…n gets broken during a reindex (#6418)

Bug description:
        During a reindex, the entryrdn index is built at the end from
        each entry in the suffix.
        If one entry has a RDN that is identical to the suffix DN,
        then entryrdn_lookup_dn may erroneously return the suffix DN
        as the DN of the entry.

Fix description:
        When the lookup entry has no parent (because index is under
        work) the loop lookup the entry using the RDN.
        If this RDN matches the suffix DN, then it exits from the loop
        with the suffix DN.
        Before exiting it checks that the original lookup entryID
        is equal to suffix entryID. If it does not match
        the function fails and then the DN from the entry will be
        built from id2enty

fixes: #6417

Reviewed by: Pierre Rogier, Simon Pichugin (Thanks !!!)
tbordaz added a commit that referenced this issue Dec 2, 2024
@tbordaz
Issue 6417 - If an entry RDN is identical to the suffix, then Entryrd…
64bd885 
…n gets broken during a reindex (#6418)

Bug description:
        During a reindex, the entryrdn index is built at the end from
        each entry in the suffix.
        If one entry has a RDN that is identical to the suffix DN,
        then entryrdn_lookup_dn may erroneously return the suffix DN
        as the DN of the entry.

Fix description:
        When the lookup entry has no parent (because index is under
        work) the loop lookup the entry using the RDN.
        If this RDN matches the suffix DN, then it exits from the loop
        with the suffix DN.
        Before exiting it checks that the original lookup entryID
        is equal to suffix entryID. If it does not match
        the function fails and then the DN from the entry will be
        built from id2enty

fixes: #6417

Reviewed by: Pierre Rogier, Simon Pichugin (Thanks !!!)
tbordaz added a commit that referenced this issue Dec 2, 2024
@tbordaz
Issue 6417 - If an entry RDN is identical to the suffix, then Entryrd…
cd07157 
…n gets broken during a reindex (#6418)

Bug description:
        During a reindex, the entryrdn index is built at the end from
        each entry in the suffix.
        If one entry has a RDN that is identical to the suffix DN,
        then entryrdn_lookup_dn may erroneously return the suffix DN
        as the DN of the entry.

Fix description:
        When the lookup entry has no parent (because index is under
        work) the loop lookup the entry using the RDN.
        If this RDN matches the suffix DN, then it exits from the loop
        with the suffix DN.
        Before exiting it checks that the original lookup entryID
        is equal to suffix entryID. If it does not match
        the function fails and then the DN from the entry will be
        built from id2enty

fixes: #6417

Reviewed by: Pierre Rogier, Simon Pichugin (Thanks !!!)
tbordaz added a commit that referenced this issue Dec 2, 2024
@tbordaz
Issue 6417 - If an entry RDN is identical to the suffix, then Entryrd…
4465cf4 
…n gets broken during a reindex (#6418)

Bug description:
        During a reindex, the entryrdn index is built at the end from
        each entry in the suffix.
        If one entry has a RDN that is identical to the suffix DN,
        then entryrdn_lookup_dn may erroneously return the suffix DN
        as the DN of the entry.

Fix description:
        When the lookup entry has no parent (because index is under
        work) the loop lookup the entry using the RDN.
        If this RDN matches the suffix DN, then it exits from the loop
        with the suffix DN.
        Before exiting it checks that the original lookup entryID
        is equal to suffix entryID. If it does not match
        the function fails and then the DN from the entry will be
        built from id2enty

fixes: #6417

Reviewed by: Pierre Rogier, Simon Pichugin (Thanks !!!)
@tbordaz
Copy link
Contributor Author

tbordaz commented Dec 2, 2024

fd62700..99e6707 main
e56ce11..63000bf 389-ds-base-3.0
ff9b909..7acdd65 389-ds-base-2.5
2b040a9..bf8a8f3 389-ds-base-2.4
0fe972f..f42fdc1 389-ds-base-2.3
9b5efd9..ccbb8ba 389-ds-base-2.2
b03d88e..37b4598 389-ds-base-2.1
a3a7387..cd07157 389-ds-base-2.0
6e376d0..64bd885 389-ds-base-1.4.4
24cc58f..4465cf4 389-ds-base-1.4.3

tbordaz added a commit to tbordaz/389-ds-base that referenced this issue Dec 20, 2024
@tbordaz
Issue 6417 - (2nd) If an entry RDN is identical to the suffix, then E…
feab869 
…ntryrdn gets broken during a reindex

Bug description:
	The primary fix has a flaw as it assumes that the
	suffix ID is '1'.
	If the RUV entry is the first entry of the database
	the server loops indefinitely

Fix description:
	Read the suffix ID from the entryrdn index

fixes: 389ds#6417

Reviewed by: Pierre Rogier (reviewed the first fix)
@tbordaz tbordaz mentioned this issue Dec 20, 2024
Merged
tbordaz added a commit to tbordaz/389-ds-base that referenced this issue Dec 20, 2024
@tbordaz
Issue 6417 - (2nd) If an entry RDN is identical to the suffix, then E…
6c625d3 
…ntryrdn gets broken during a reindex

Bug description:
	The primary fix has a flaw as it assumes that the
	suffix ID is '1'.
	If the RUV entry is the first entry of the database
	the server loops indefinitely

Fix description:
	Read the suffix ID from the entryrdn index

fixes: 389ds#6417

Reviewed by: Pierre Rogier (reviewed the first fix)
@tbordaz
Copy link
Contributor Author

tbordaz commented Dec 20, 2024

A regression was found with the original fix. The regression is detected in 1.4.3 but hidden since 2.3.
This is fixed by the 2nd PR under review

@tbordaz tbordaz reopened this Dec 20, 2024
tbordaz added a commit to tbordaz/389-ds-base that referenced this issue Jan 2, 2025
@tbordaz
Issue 6417 - (2nd) If an entry RDN is identical to the suffix, then E…
3e6c70e 
…ntryrdn gets broken during a reindex

Bug description:
	The primary fix has a flaw as it assumes that the
	suffix ID is '1'.
	If the RUV entry is the first entry of the database
	the server loops indefinitely

Fix description:
	Read the suffix ID from the entryrdn index

fixes: 389ds#6417

Reviewed by: Pierre Rogier (also reviewed the first fix)
@tbordaz tbordaz closed this as completed in a79887e Jan 6, 2025
tbordaz added a commit that referenced this issue Jan 6, 2025
@tbordaz
Issue 6417 - (2nd) If an entry RDN is identical to the suffix, then E…
396e259 
…ntryrdn gets broken during a reindex (#6460)

Bug description:
	The primary fix has a flaw as it assumes that the
	suffix ID is '1'.
	If the RUV entry is the first entry of the database
	the server loops indefinitely

Fix description:
	Read the suffix ID from the entryrdn index

fixes: #6417

Reviewed by: Pierre Rogier (also reviewed the first fix)
tbordaz added a commit that referenced this issue Jan 6, 2025
@tbordaz
Issue 6417 - (2nd) If an entry RDN is identical to the suffix, then E…
19cd1d2 
…ntryrdn gets broken during a reindex (#6460)

Bug description:
	The primary fix has a flaw as it assumes that the
	suffix ID is '1'.
	If the RUV entry is the first entry of the database
	the server loops indefinitely

Fix description:
	Read the suffix ID from the entryrdn index

fixes: #6417

Reviewed by: Pierre Rogier (also reviewed the first fix)
tbordaz added a commit that referenced this issue Jan 6, 2025
@tbordaz
Issue 6417 - (2nd) If an entry RDN is identical to the suffix, then E…
6468c94 
…ntryrdn gets broken during a reindex (#6460)

Bug description:
	The primary fix has a flaw as it assumes that the
	suffix ID is '1'.
	If the RUV entry is the first entry of the database
	the server loops indefinitely

Fix description:
	Read the suffix ID from the entryrdn index

fixes: #6417

Reviewed by: Pierre Rogier (also reviewed the first fix)
tbordaz added a commit that referenced this issue Jan 6, 2025
@tbordaz
Issue 6417 - (2nd) If an entry RDN is identical to the suffix, then E…
df83285 
…ntryrdn gets broken during a reindex (#6460)

Bug description:
	The primary fix has a flaw as it assumes that the
	suffix ID is '1'.
	If the RUV entry is the first entry of the database
	the server loops indefinitely

Fix description:
	Read the suffix ID from the entryrdn index

fixes: #6417

Reviewed by: Pierre Rogier (also reviewed the first fix)
tbordaz added a commit that referenced this issue Jan 6, 2025
@tbordaz
Issue 6417 - (2nd) If an entry RDN is identical to the suffix, then E…
0fa34c1 
…ntryrdn gets broken during a reindex (#6460)

Bug description:
	The primary fix has a flaw as it assumes that the
	suffix ID is '1'.
	If the RUV entry is the first entry of the database
	the server loops indefinitely

Fix description:
	Read the suffix ID from the entryrdn index

fixes: #6417

Reviewed by: Pierre Rogier (also reviewed the first fix)
tbordaz added a commit that referenced this issue Jan 6, 2025
@tbordaz
Issue 6417 - (2nd) If an entry RDN is identical to the suffix, then E…
3a0fa37 
…ntryrdn gets broken during a reindex (#6460)

Bug description:
	The primary fix has a flaw as it assumes that the
	suffix ID is '1'.
	If the RUV entry is the first entry of the database
	the server loops indefinitely

Fix description:
	Read the suffix ID from the entryrdn index

fixes: #6417

Reviewed by: Pierre Rogier (also reviewed the first fix)
tbordaz added a commit that referenced this issue Jan 6, 2025
@tbordaz
Issue 6417 - (2nd) If an entry RDN is identical to the suffix, then E…
09ef190 
…ntryrdn gets broken during a reindex (#6460)

Bug description:
	The primary fix has a flaw as it assumes that the
	suffix ID is '1'.
	If the RUV entry is the first entry of the database
	the server loops indefinitely

Fix description:
	Read the suffix ID from the entryrdn index

fixes: #6417

Reviewed by: Pierre Rogier (also reviewed the first fix)
tbordaz added a commit that referenced this issue Jan 6, 2025
@tbordaz
Issue 6417 - (2nd) If an entry RDN is identical to the suffix, then E…
f9a5402 
…ntryrdn gets broken during a reindex (#6460)

Bug description:
	The primary fix has a flaw as it assumes that the
	suffix ID is '1'.
	If the RUV entry is the first entry of the database
	the server loops indefinitely

Fix description:
	Read the suffix ID from the entryrdn index

fixes: #6417

Reviewed by: Pierre Rogier (also reviewed the first fix)
tbordaz added a commit that referenced this issue Jan 6, 2025
@tbordaz
Issue 6417 - (2nd) If an entry RDN is identical to the suffix, then E…
9b14e7d 
…ntryrdn gets broken during a reindex (#6460)

Bug description:
	The primary fix has a flaw as it assumes that the
	suffix ID is '1'.
	If the RUV entry is the first entry of the database
	the server loops indefinitely

Fix description:
	Read the suffix ID from the entryrdn index

fixes: #6417

Reviewed by: Pierre Rogier (also reviewed the first fix)
@tbordaz
Copy link
Contributor Author

tbordaz commented Jan 6, 2025

f4553b8..a79887e main
3edcb75..396e259 389-ds-base-3.0
b5a8c5a..19cd1d2 389-ds-base-2.5
e301efb..6468c94 389-ds-base-2.4
9c40f3d..df83285 389-ds-base-2.3
c475c8c..0fa34c1 389-ds-base-2.2
51b11a7..3a0fa37 389-ds-base-2.1
784b6e3..09ef190 389-ds-base-2.0
6cc6112..f9a5402 389-ds-base-1.4.4
b3a8146..9b14e7d 389-ds-base-1.4.3

@tbordaz tbordaz reopened this Jan 6, 2025
@tbordaz
Copy link
Contributor Author

tbordaz commented Jan 6, 2025

The backport in branch 1.4.3 up to 2.4 was invalid. I fixed it 2.0 to 2.4
6468c94..ecfca3c 389-ds-base-2.4
df83285..db97133 389-ds-base-2.3
0fa34c1..dc7e8c8 389-ds-base-2.2
3a0fa37..843ef41 389-ds-base-2.1
09ef190..52ebef2 389-ds-base-2.0

I still have to fix it for 1.4.3 and 1.4.4

@mreynolds389
Copy link
Contributor

@tbordaz - you missed 2.6 branch :-)

@tbordaz
Copy link
Contributor Author

tbordaz commented Jan 7, 2025

The backport in branch 1.4.3 up to 2.4 was invalid. Fixe 1.4.3 and 1.4.4
f9a5402..d0b1841 389-ds-base-1.4.4
9b14e7d..a61d02e 389-ds-base-1.4.3

tbordaz added a commit that referenced this issue Jan 7, 2025
@tbordaz
Issue 6417 - (2nd) If an entry RDN is identical to the suffix, then E…
26210d1 
…ntryrdn gets broken during a reindex (#6460)

Bug description:
	The primary fix has a flaw as it assumes that the
	suffix ID is '1'.
	If the RUV entry is the first entry of the database
	the server loops indefinitely

Fix description:
	Read the suffix ID from the entryrdn index

fixes: #6417

Reviewed by: Pierre Rogier (also reviewed the first fix)
@tbordaz
Copy link
Contributor Author

tbordaz commented Jan 7, 2025

Missed 2.6 branch (thanks @mreynolds389 for the heads up)
444354b..26210d1 389-ds-base-2.6

tbordaz added a commit to tbordaz/389-ds-base that referenced this issue Jan 8, 2025
@tbordaz
Issue 6417 - (3rd) If an entry RDN is identical to the suffix, then E…
3303e14 
…ntryrdn gets broken during a reindex

Bug description:
	The previous fix had a flaw.
	In case entryrdn_lookup_dn is called with an undefined suffix
	the lookup of the suffix trigger a crash.
	For example it can occur during internal search of an
	unexisting map (view plugin).
	The issue exists in all releases but is hidden since 2.3.

Fix description:
	testing the suffix is defined

fixes: 389ds#6417

Reviewed by:
@tbordaz tbordaz linked a pull request Jan 8, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbordaz tbordaz

Labels
priority_high need urgent fix / highly valuable / easy to fix
Projects
None yet
Milestone
1.4.3
2 participants
@mreynolds389 @tbordaz