Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade PHP-CS-Fixer from 3.8.0 to 3.40.0 #5005

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

Gustry
Copy link
Member

@Gustry Gustry commented Nov 25, 2024

It will be manually backported to all active branches if necessary (to avoid backport conflicts)

@Gustry Gustry added run end2end If the PR must run end2end tests or not php Pull requests that update Php code labels Nov 25, 2024
@github-actions github-actions bot added this to the 3.10.0 milestone Nov 25, 2024
@Gustry Gustry force-pushed the upgrade-php-cs-fixer branch from 3e5e691 to 431356e Compare November 25, 2024 18:57
@Gustry Gustry requested review from laurentj and nworr November 26, 2024 07:49
@Gustry Gustry marked this pull request as ready for review November 26, 2024 07:49
@Gustry
Copy link
Member Author

Gustry commented Nov 28, 2024

The diff is smaller if you use the "Hide whatespaces" option in GitHub.

@nworr I would appreciate your feedback on this one if you have some time ;-)

Copy link
Contributor

@nworr nworr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many files updated, but i think it will not introduce much conflicts with pending PRs.

Thanks

@Gustry Gustry merged commit 5c04749 into 3liz:master Dec 2, 2024
13 checks passed
@Gustry Gustry deleted the upgrade-php-cs-fixer branch December 2, 2024 13:11
nboisteault pushed a commit to nboisteault/lizmap-web-client that referenced this pull request Dec 12, 2024
Upgrade PHP-CS-Fixer from 3.8.0 to 3.40.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
php Pull requests that update Php code run end2end If the PR must run end2end tests or not
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants