include layer opacity info for embedded layers

[mind84]

Backport for #4964

Funded by Faunalia

[Gustry]

LGTM according to LGTM on the parent PR ;-)

[Gustry]

I wonder how CI could pass, I'm confused as well, from other PR on the 3.8 branch.

But now, when I'm on the landing page, I have a 500 error from PHP :

[0]	Call to a member function xpath() on null
  /srv/lzm/lizmap/modules/lizmap/lib/Project/QgisProject.php	654
 /
 array (   'module' => 'view',   'action' => 'default:index', )
 ref:Unknown referer

	0	Lizmap\Project\QgisProject->xpathQuery()	/srv/lzm/lizmap/modules/lizmap/lib/Project/QgisProject.php : 390
	1	Lizmap\Project\QgisProject->setLayerOpacity()	/srv/lzm/lizmap/modules/lizmap/lib/Project/QgisProject.php : 346
	2	Lizmap\Project\QgisProject->setPropertiesAfterRead()	/srv/lzm/lizmap/modules/lizmap/lib/Project/Project.php : 236
	3	Lizmap\Project\Project->readProject()	/srv/lzm/lizmap/modules/lizmap/lib/Project/Project.php : 148
	4	Lizmap\Project\Project->__construct()	/srv/lzm/lizmap/modules/lizmap/lib/Project/Repository.php : 294
	5	Lizmap\Project\Repository->getProject()	/srv/lzm/lizmap/modules/lizmap/lib/Project/Repository.php : 388
	6	Lizmap\Project\Repository->getProjectsMetadata()	/srv/lzm/lizmap/modules/lizmap/classes/lizmapRepository.class.php : 166
	7	lizmapRepository->getProjectsMetadata()	/srv/lzm/lizmap/modules/view/zones/main_view.zone.php : 64
	8	main_viewZone->_prepareTpl()	/srv/lzm/lizmap/vendor/jelix/jelix/lib/jelix/utils/jZone.class.php : 282
	9	jZone->_createContent()	/srv/lzm/lizmap/vendor/jelix/jelix/lib/jelix/utils/jZone.class.php : 217
	10	jZone->getContent()	/srv/lzm/lizmap/vendor/jelix/jelix/lib/jelix/utils/jZone.class.php : 373
	11	jZone::_callZone()	/srv/lzm/lizmap/vendor/jelix/jelix/lib/jelix/utils/jZone.class.php : 114
	12	jZone::get()	/srv/lzm/lizmap/vendor/jelix/jelix/lib/jelix/tpl/jTpl.class.php : 52
	13	jTpl->assignZone()	/srv/lzm/lizmap/modules/view/controllers/default.classic.php : 158
	14	defaultCtrl->index()	/srv/lzm/lizmap/vendor/jelix/jelix/lib/jelix/core/jCoordinator.class.php : 266
	15	jCoordinator->process()	/srv/lzm/lizmap/www/index.php : 23

Which looks linked to this PR ?

Am I wrong ?

[mind84]

Hi @Gustry,

I'm surprised too!

Anyway, the issue is related to the xpathQuery function, it's different between versions:

versions >= 3.9:

lizmap-web-client/lizmap/modules/lizmap/lib/Project/QgisProject.php

Line 656 in 0766319

$ret = $this->getXml()->xpath($query);

version 3.8:

lizmap-web-client/lizmap/modules/lizmap/lib/Project/QgisProject.php

Line 654 in d691b68

$ret = $this->xml->xpath($query);

Basically in 3.8 the property $xml is accessed directly while in newer versions Lizmap first checks if this property exists.

This is the commit:

1e9be74

Maybe coluld be backported to 3.8? Any drawbaks? @rldhont,

[rldhont]

@mind84 the commit 1e9be74 is part of #4765 and was made has a first step for #4819

If you can provide a fix to release_3_8, it's welcome.