Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Child feature table items not displayed in child popup #5023

Closed
1 task done
erw-1 opened this issue Nov 29, 2024 · 2 comments · Fixed by #5037
Closed
1 task done

[Bug]: Child feature table items not displayed in child popup #5023

erw-1 opened this issue Nov 29, 2024 · 2 comments · Fixed by #5037
Labels

Comments

@erw-1
Copy link
Contributor

erw-1 commented Nov 29, 2024

What is the bug? (in English)

In a popup, when a feature table item is selected, other items are automatically hidden, as expected. However, if there is another feature table in the selected child feature's popup, new items are also hidden before they can be picked, because they share the same CSS selector.

You could introduce a hierarchy level into the selector to differentiate between parent and child feature tables.

Steps to reproduce the issue

IN QGIS:

  1. Setup a lizmap-features-table html element in the popup of the parent layer
  2. Setup a second lizmap-features-table in the popup of the child layer

IN LIZMAP WEB CLIENT:

  1. Click one of the items of the lizmap-features-table (the child popup unwraps)
    Bug happens here, the lizmap-features-table items from the child layer popup are not displayed
    Video example (FRA): https://youtu.be/zZafmypUBVs

Versions, safeguards, check summary etc

Versions :

  • Lizmap Web Client : 3.8.4-pre.8071 - commit ce348b6 ce348b697
  • Lizmap plugin : 4.4.5
  • QGIS Desktop : 3.34.12
  • QGIS Server : 3.34.11
  • Py-QGIS-Server : 1.9.1
  • QGIS Server plugin DataPlotly : 4.2.0
  • QGIS Server plugin atlasprint : 3.4.1
  • QGIS Server plugin cadastre : 1.20.0
  • QGIS Server plugin lizmap_server : 2.11.2
  • QGIS Server plugin wfsOutputExtension : 1.8.2
List of Lizmap Web Client modules :
* cadastre : 2.1.4
List of safeguards :
* Mode : normal
* Allow parent folder : yes
* Number of parent : 2 folder(s)
* Prevent other drive : yes
* Prevent PG service : yes
* Prevent PG Auth DB : yes
* Force PG user&pass : yes
* Prevent ECW : yes

Check Lizmap plugin

  • I have done the step just before in the Lizmap QGIS desktop plugin before opening this ticket. Otherwise, my ticket is not considered valid and might get closed.

Operating system

Windows 10/11

Browsers

Microsoft Edge

Browsers version

Edge 131.0.2903.70

Relevant log output

No response

@erw-1 erw-1 added the bug label Nov 29, 2024
@erw-1 erw-1 changed the title [Bug]: Child feature table [Bug]: Child feature table items not displayed in child popup Nov 29, 2024
@rldhont
Copy link
Collaborator

rldhont commented Nov 29, 2024

@erw-1 do you have a solution or a proposition to fix it ?

@erw-1
Copy link
Contributor Author

erw-1 commented Nov 29, 2024

Yes, in map.css, you can replace:

div.lizmap-features-table.popup-displayed div.lizmap-features-table-container div.lizmap-features-table-item {
    display: none;
}

with:

div.lizmap-features-table.popup-displayed > div.lizmap-features-table-container > div.lizmap-features-table-item:not(.popup-displayed) {
    display: none;
}

win

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants