PHP: reading GetFeature GeoJSON as a stream with JSON-Machine #5137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rldhont
added
refactoring
run end2end
rldhont
force-pushed
the
json-machine
branch
2 times, most recently
from
b359b97 to
ee73176
Compare
|
I just tested this PR with the Land-use project data (the one visible here https://demo.lizmap.com/lizmap/index.php/view/map?repository=features&project=land_use) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON-Machine is a very easy to use and memory efficient drop-in replacement for inefficient iteration of big JSON files or streams for PHP https://github.com/halaxa/json-machine
In some part of Lizmap PHP code, GetFeature GeoJSON are read in an inefficient way.