Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate lyon campus #319

Open
1 task done
42atomys opened this issue Dec 11, 2022 · 5 comments · May be fixed by #640
Open
1 task done

feat: integrate lyon campus #319

42atomys opened this issue Dec 11, 2022 · 5 comments · May be fixed by #640
Assignees
Labels
aspect/interface 🕹 Concerns end-users' experience with the software domain/obvious 🟩 Represents the "known knowns" issue. It's Obviously good first issue Good for newcomers help wanted Extra attention is needed stale/lock 🔒 This prevent slote process on this object type/improvement ✨ Improvement to an existing feature

Comments

@42atomys
Copy link
Owner

42atomys commented Dec 11, 2022

Special issue : Campus integration

Integrate the campus of lyon on s42

🎁 If you come from good first issue Good for newcomers or help wanted Extra attention is needed : How to add a campus on s42

Code of Conduct

  • I agree to follow this project's Code of Conduct
@42atomys 42atomys converted this from a draft issue Dec 11, 2022
@42atomys 42atomys added this to the 3.0 Stable Release 🎉 milestone Dec 11, 2022
@github-actions github-actions bot added the state/triage 🚦 Has not been triaged & therefore, not ready for work label Dec 11, 2022
@42atomys 42atomys added help wanted Extra attention is needed good first issue Good for newcomers type/feature ⭐ Addition of new feature aspect/interface 🕹 Concerns end-users' experience with the software domain/obvious 🟩 Represents the "known knowns" issue. It's Obviously type/improvement ✨ Improvement to an existing feature and removed state/triage 🚦 Has not been triaged & therefore, not ready for work type/feature ⭐ Addition of new feature labels Dec 11, 2022
@42atomys 42atomys added the stale/lock 🔒 This prevent slote process on this object label Jan 11, 2023
@gd-harco
Copy link

gd-harco commented Oct 3, 2024

Hi,
just here to say that Iḿ willing to do the job. i'll go read the process for contributing and work on it in my spare time

@42atomys
Copy link
Owner Author

42atomys commented Oct 3, 2024

Hi @gd-harco, noted !

We currently have a lot of issues with devcontainers.. so don't be afraid to ping me to test / validate your contribution

@gd-harco
Copy link

gd-harco commented Oct 9, 2024

Hi @42atomys,
sorry to bother you. The map is created, but I couldn't commit it. I'm getting a weird error message that I guess is coming from the integrated linter. Is it related to the dev container issue you wee mentioning earlier ?
Here is the error message I get when trying "git commit" while inside the dev container

file:///usr/local/share/nvm/versions/node/v20.18.0/lib/node_modules/@commitlint/cli/lib/cli.js:132
        throw err;
        ^

Error [ERR_UNSUPPORTED_DIR_IMPORT]: Directory import '/usr/local/share/nvm/versions/node/v20.18.0/lib/node_modules/@commitlint/config-conventional' is not supported resolving ES modules imported from /usr/local/share/nvm/versions/node/v20.18.0/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js
Did you mean to import "/usr/local/share/nvm/versions/node/v20.18.0/lib/node_modules/@commitlint/config-conventional/lib/index.js"?
    at finalizeResolution (node:internal/modules/esm/resolve:259:11)
    at moduleResolve (node:internal/modules/esm/resolve:933:10)
    at defaultResolve (node:internal/modules/esm/resolve:1169:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:542:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:510:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:239:38)
    at ModuleLoader.import (node:internal/modules/esm/loader:472:34)
    at defaultImportModuleDynamicallyForModule (node:internal/modules/esm/utils:214:31)
    at importModuleDynamicallyCallback (node:internal/modules/esm/utils:253:12)
    at dynamicImport (file:///usr/local/share/nvm/versions/node/v20.18.0/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js:10:88) {
  code: 'ERR_UNSUPPORTED_DIR_IMPORT',
  url: 'file:///usr/local/share/nvm/versions/node/v20.18.0/lib/node_modules/@commitlint/config-conventional'
}

Node.js v20.18.0 

@42atomys
Copy link
Owner Author

42atomys commented Oct 9, 2024

Hi @gd-harco, we have an issue with dev container :( And I don't have take time to fix it shame on me ! (#614)

You can commit the map open a PR, and I do the rest for you! Don't worry if error or linter issue, I will check and fix it as you can't do that.

That not your fault, the devcontainer just stop work 3 months ago for new contributor

@gd-harco
Copy link

It appears that I can't link the PR to the issue, it's number #640.

@42atomys 42atomys linked a pull request Oct 10, 2024 that will close this issue
3 tasks
@42atomys 42atomys removed their assignment Oct 10, 2024
@42atomys 42atomys moved this from 🗞 Wait for maps to 🎉 Planned in S42 - Campus integration Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect/interface 🕹 Concerns end-users' experience with the software domain/obvious 🟩 Represents the "known knowns" issue. It's Obviously good first issue Good for newcomers help wanted Extra attention is needed stale/lock 🔒 This prevent slote process on this object type/improvement ✨ Improvement to an existing feature
Projects
Status: 🎉 Planned
Development

Successfully merging a pull request may close this issue.

2 participants