Adding the fit_model function
#277
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added full formula creator
added fixed effects string generator
1. Put ‘data= simdf_time’ inside the function like( ). 2. Delete ‘marginal = bru_mapper_marginal(qexp, rate = 1)’, ‘group_mapper = bru_mapper(mesh)’, and ‘qexp <- stats::qnorm(p, mean = 0, sd = 1, lower.tail = TRUE, log.p = FALSE)’ simply because they keep reporting errors.
fix constrained model run errors
Iss273/new data sets
XueqingYin
reviewed
Nov 24, 2023
There was a problem hiding this comment.
Hi , I found several issues in fit_model.R and fit_model.Rmd.
for fit_model.R:
- The purpose of having two
inlabru::like()in this model is not clear to me. Maybe it's useful to explain the aim of eachlike(), and the problem that this model is solving? - Do you want to include the arguments (such as max.edge) that control mesh resolution when creating mesh? At present, they are missing in
fm_mesh_2d_inla(), and I foundmax_edge_meshis not used. - The object types for
space_variables,spacetime_variables, anddataneed clear description. Ifspace_variablesandspacetime_variablesarelistobjects as described now at the beginning of the script, thendata[space_variables]will give an error "Error in .subset2(x, i, exact = exact) : invalid subscript type 'list'". To avoid this,space_variablesandspacetime_variablesshould be a vector of spatial and spacetime variables, respectively. - The input for the argument
locationsshould be a matrix of point locations, rather than a list of coordinates
for fit_model.Rmd:
process_coordsargument does not exist in thefit_model()functionspace_variablesandspacetime_variablesare missing in this rain example- If I remember it correctly,
inlabru::brurequires the time index to start from 1, whereas it now starts from 5 in this example
|
For the fit_model.rmd we actually stopped using that and it should be removed because we switched to using the test_fit_model.rmd |
|
Also, |
|
We didn't put the arguments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add a
fit_modelfunction that in one line will createfit_model- generate formula #275fit_model- meshing function #274fit_model- fitting the model #276stylerrun over codeCHANGELOG.mdfile if fixing a bug or adding a new featureDESCRIPTION