Onnx Parser: Function AddConvLayerWithDepthwiseConv with bias has logical error

[haibozhang123]

right logic code :

DepthwiseConvolution2dDescriptor desc;
desc.m_PadLeft = convDesc.m_PadLeft;
desc.m_PadRight = convDesc.m_PadRight;
desc.m_PadTop = convDesc.m_PadTop;
desc.m_PadBottom = convDesc.m_PadBottom;
desc.m_StrideX = convDesc.m_StrideX;
desc.m_StrideY = convDesc.m_StrideY;
desc.m_BiasEnabled = convDesc.m_BiasEnabled;
if (node.input_size() == 3) {
desc.m_BiasEnabled = true;
}

error logic code ：

DepthwiseConvolution2dDescriptor desc;
desc.m_PadLeft = convDesc.m_PadLeft;
desc.m_PadRight = convDesc.m_PadRight;
desc.m_PadTop = convDesc.m_PadTop;
desc.m_PadBottom = convDesc.m_PadBottom;
desc.m_StrideX = convDesc.m_StrideX;
desc.m_StrideY = convDesc.m_StrideY;
desc.m_BiasEnabled = convDesc.m_BiasEnabled;

[Colm-in-Arm]

Hi,

Good spot. The value of m_BiasEnabled will be the default value, false. However, if you look further down in the section handling the bias tensor you'll see it sets "desc.m_BiasEnabled = true;" The line "desc.m_BiasEnabled = convDesc.m_BiasEnabled;" is ensuring the default value is set.

Colm.