Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request : Majora's Mask Japanese ROM #145

Open
Dromi0331 opened this issue May 14, 2024 · 1 comment
Open

Feature request : Majora's Mask Japanese ROM #145

Dromi0331 opened this issue May 14, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Dromi0331
Copy link

When I patch a Japanese ROM, the language is forced to English.
Do you plan to support Japanese ROMs for majora's mask in the future?

Or is there any way to keep the Japanese language after applying the patch?

@Dromi0331 Dromi0331 added the enhancement New feature or request label May 14, 2024
@Dromi0331 Dromi0331 changed the title Majora's Mask Japanese ROM Feature request : Majora's Mask Japanese ROM May 14, 2024
@Admentus64
Copy link
Owner

Admentus64 commented May 19, 2024

No support planned for Japanese Majora's Mask.

Some else other than me would need to submit a Pull Request for this.

You might also be misunderstanding this, but you aren't patching a Japanese ROM. The Patcher64+ Tool only accepts the US Rev0 ROM. Any other ROM you provide and got accepted just ends up being converted into the US Rev0 ROM. The US Rev0 ROM has no Japanese language in it, unlike the OoT US ROMs.

Japanese is drastically different from any other language we support, which are western languages. Japanese uses a completely different format which is incompatible with English. The other languages we support work because they are compatible with the English format. One has to backport this Japanese format support into the US Rev0 ROM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants