Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANDROID] browserInfo doesn't return from DropIn #385

Closed
ahmetgsu opened this issue Mar 7, 2024 · 3 comments
Closed

[ANDROID] browserInfo doesn't return from DropIn #385

ahmetgsu opened this issue Mar 7, 2024 · 3 comments
Labels
bug Something isn't working iOS SDK This feature is missing on latest adyen-ios

Comments

@ahmetgsu
Copy link

ahmetgsu commented Mar 7, 2024

Describe the bug
After upgrading the library from v1.2.0 to v2.0.0 BETA2, Android version is not working properly.
Previously, the data parameter of the onSubmit function had browserInfo and the data.amount.value was an integer. Now, there is no browserInfo data, and data.amount.value comes as string. DropIn is dismissed after the first step.

To Reproduce
Steps to reproduce the behavior:

  1. on Android, fill the credit card details on DropIn
  2. Click on "Confirm preautorization" button (amount.value = 0)
  3. See the DropIn is dismissed

Expected behavior
The 3DS auth screen should appear on the screen after completing the credit card details

Smartphone (please complete the following information):

  • Device: Pixel 4
  • OS: API 34
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Should we populate browserInfo prop manually on Android?

@ahmetgsu ahmetgsu added the bug report when a bug report is created label Mar 7, 2024
@descorp
Copy link
Contributor

descorp commented Apr 17, 2024

Hey @ahmetgsu

no browserInfo data

This is known misalignment on iOS and Android. We are looking to remove browserInfo on iOS.

Context:
browserInfo were essential for web-based 3DS1 flow. However 3DS1 is discontinued and we are encouraging usage of 3DS2 Native flow on mobile instead.
To enable native 3DS2 - make sure to send authenticationData and paymentMethod.threeDS2SdkVersion
See Native 3DS2 Drop-in integration docs.

  "paymentMethod": {
    ...,
    "threeDS2SdkVersion": "XXXX"
  },
  "authenticationData": {
    "threeDSRequestData": {
      "nativeThreeDS": "preferred"
    }
  }

data.amount.value comes as string

Hm.. This is indeed bug on our side! Thanks for reporting it @ahmetgsu 💚
PR #425

@descorp descorp added bug Something isn't working and removed bug report when a bug report is created labels Apr 17, 2024
@descorp descorp added this to the 2.0.0-rc1 milestone Apr 17, 2024
@descorp descorp changed the title [ANDROID] browserInfo doesn't return from DropIn, amount.value returns as string [ANDROID] browserInfo doesn't return from DropIn Apr 29, 2024
@descorp descorp added the iOS SDK This feature is missing on latest adyen-ios label Apr 29, 2024
@descorp descorp removed this from the 2.0.0-rc1 milestone Apr 29, 2024
@descorp
Copy link
Contributor

descorp commented May 3, 2024

Fix for data.amount.value released on 2.0.0-rc.1

@descorp
Copy link
Contributor

descorp commented May 3, 2024

I am going to close this ticket, since remaining part is a duplicate of #164

@descorp descorp closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working iOS SDK This feature is missing on latest adyen-ios
Projects
None yet
Development

No branches or pull requests

2 participants