Move implementation logic/details from BackupClientInterface
to another private trait
#198
Labels
good first issue
Good for newcomers
What is currently missing?
Currently if you look at https://github.com/aiven/guardian-for-apache-kafka/blob/main/core-backup/src/main/scala/io/aiven/guardian/kafka/backup/BackupClientInterface.scala both the public interface (i.e. all methods that are public) in
BackupClientInterface
is mixed with all of the implementation details/backup core logic which are privateHow could this be improved?
All of the private implementation details (and implementation of the core logic behind
BackupClientInterface
itself) should be moved to another trait, likely calledBackupClientInterfaceImpl
which is package private.BackupClientInterface
can then extendBackupClientInterfaceImpl
.This will make it ultra clear what is the public interface, i.e.
BackupClientInterface
. Can also help with Java interopt sinceBackupClientInterface
will essentially be the same as a Javainterface
.Is this a feature you would work on yourself?
The text was updated successfully, but these errors were encountered: