Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for styling + RTL #5

Open
ihadabs opened this issue Jul 24, 2023 · 1 comment
Open

Support for styling + RTL #5

ihadabs opened this issue Jul 24, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@ihadabs
Copy link

ihadabs commented Jul 24, 2023

Hi there,
Thanks for building this package, I have tried many and this is the best package ❤️🙏.

Can some parameters be added?

  1. titleStyle useful for using custom fonts, colors, ...

or maybe a

  1. titleBuilder useful for using custom text style + adding some padding (above and below see pic)
    titleBuilder would be a Widget Function(BuildContext context, String title)

  2. backgroundColor for using a custom color other than the context theme

  3. searchHint useful for supporting other languages

  4. searchStyle usefull for custom fonts, ...

  5. searchBackgroundColor useful for supporting other themes (see below pic its white on dark theme)

Other issues:

  1. RTL support, maybe need using flutter utils Directionality.of(this) or AligmentDirectional
  2. Tone picker does not disappear when closing the widget

When LTR langs:
CleanShot 2023-07-25 at 02 35 39@2x

When RTL langs (tone color is broken):
CleanShot 2023-07-25 at 02 36 02@2x

The tone picker is stuck (after closing the picker), maybe need handling in dispose:
CleanShot 2023-07-25 at 02 46 08@2x

@Alfaizkhan
Copy link
Owner

Great catches @ihadabs
Will resolve above all issues ASAP.
Thank you for suggestions😀

@Alfaizkhan Alfaizkhan self-assigned this Jul 27, 2023
@Alfaizkhan Alfaizkhan added the enhancement New feature or request label Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants