Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Include host identifier with disks #542

Closed
Gorian opened this issue Nov 10, 2023 · 8 comments
Closed

[FEAT] Include host identifier with disks #542

Gorian opened this issue Nov 10, 2023 · 8 comments

Comments

@Gorian
Copy link

Gorian commented Nov 10, 2023

Is your feature request related to a problem? Please describe.
Scrutiny doesn't seem to include hostnames or any other identifiers when displaying disks in the dashboard. When you run the scrutiny server with multiple clients, this is an issue as you don't know which disk belongs to which hosts.

Describe the solution you'd like
Include an option to display server hostnames with the disks. Maybe an option to set the hostname via variable, as containers won't have a usable hostname.

Additional context
As an example, these two disks are from two completely different hosts:
image

@Gorian Gorian changed the title [FEAT] [FEAT] Include host identifier to disks Nov 10, 2023
@Gorian Gorian changed the title [FEAT] Include host identifier to disks [FEAT] Include host identifier with disks Nov 10, 2023
@jeremydelattre59
Copy link

Hello,
This is already possible.
To have the hostname, you must enter the "host -> id" property in the collector.yml file.

image

Result:

image

@PrplHaz4
Copy link
Contributor

Hello, This is already possible. To have the hostname, you must enter the "host -> id" property in the collector.yml file.

For docker users this can be set via environment variable:
COLLECTOR_HOST_ID

@Gorian
Copy link
Author

Gorian commented Nov 15, 2023

Awesome, thank you so much!

@AnalogJ AnalogJ closed this as completed Nov 17, 2023
@xinmans
Copy link

xinmans commented Jan 12, 2024

thanks,can U update the docs include COLLECTOR_HOST_ID?

@PrplHaz4
Copy link
Contributor

thanks,can U update the docs include COLLECTOR_HOST_ID?

PR here #566

@Tampa
Copy link

Tampa commented Sep 21, 2024

Collector also supports this via cli as --host-id "hostname"

Should really document the available cli parameters in the collector, because --help does not list it

@AnalogJ
Copy link
Owner

AnalogJ commented Sep 21, 2024

@Tampa it should. I think you just need to run collector run --help

@Tampa
Copy link

Tampa commented Sep 21, 2024

I see, but then the general help page does not mention that each command has its own help page. I would either just have them all listen under --help or add that each command has further help pages associated with it. There aren't that many commands in the collector to really warrant splitting it up in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants