Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor Mod Incompatibility]: QuickSave #585

Open
DeLiXx opened this issue Jul 26, 2024 · 2 comments
Open

[Minor Mod Incompatibility]: QuickSave #585

DeLiXx opened this issue Jul 26, 2024 · 2 comments
Assignees
Labels
bug (visual) A visual element isn't being displayed properly. triage

Comments

@DeLiXx
Copy link

DeLiXx commented Jul 26, 2024

Mod Version

v2.3.4

Multiplayer

Single Player

Visual Settings

100% 100%

SMAPI Log

No response

Description

Hello!
Unfortunately when loading a savefile in the middle of the day using QuickSave some UI elements like the daily luck symbol and tomorrows weather duplicate. It'd be great if mod compatibility could be established.
To reproduce just create a new game with both mods installed.
Press F5 to quicksave and F7 to quickload.

image

@DeLiXx DeLiXx added bug (visual) A visual element isn't being displayed properly. triage labels Jul 26, 2024
@wulingxuan
Copy link

wulingxuan commented Aug 5, 2024

This has to do with how the mod is loaded. If the mod data is loaded when the archive is loaded and the mod data is unloaded when the return menu, this phenomenon will occur when the QuickSave is used, the old mod data is not unloaded but the mod data is loaded again when the new archive is loaded.
If QuickSave can be triggered when loading the archive (helper.Events.GameLoop.ReturnedToTitle) should be able to solve the problem, or ui2 add IQuickSaveAPI.LoadingDelegate Dispose.

See new and Dispose.

@wulingxuan
Copy link

Fix #630.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug (visual) A visual element isn't being displayed properly. triage
Projects
None yet
Development

No branches or pull requests

3 participants