-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] build
fails because of an issue in material UI
#18
Comments
Before building, make sure you copy package.json and pnpm-lock.yaml to the directory. @khorshuheng |
@bdruth Which version of Node and pnpm are you using? |
|
We are developing based on pnpm 8.5. I will see if i can reproduce the issue with the versions of node and pnpm specified above. |
Just a recommendation - it doesn't get any easier down the road to get dependabot or renovate bot setup to auto-bump dependencies and incrementally refactor things as you notice that certain dependencies keep releasing breaking changes ... at some point, you'll be overwhelmed. |
Thank you for your recommendation regarding pnpm updates. We've decided to be cautious with pnpm version upgrades for now, as major versions often introduce breaking changes that could potentially impact our codebase stability. However, we appreciate your suggestion about dependency management. We plan to implement a Dependabot configuration specifically for pnpm that will:
Thanks again for bringing this to our attention! |
Bug Description
running
pnpm run build
fails with a vite error due to an issue with the@mui/material
versionSteps to Reproduce
4c71e62
(currentmain
)make build
Expected Behavior
make build
should succeed, ideally without warnings, but we'll settle for without errors :)Browser and Version
n/a
AppFlowy Version(s)
4c71e62 (close to 0.1.1)
Screenshots
No response
Logs and Console Output
Additional Context
As
vite
is indicating when it's blowing up on -Grid2.js
-@mui/system/Unstable_Grid
doesn't exist at this version of@mui/material
- switching from6.0.0-alpha.2
to6.0.0
seems to fix it, though. The current version of@mui/material
is6.3.1
which also appears to build successfully - whether it "works" I don't know - I haven't run things locally to try them out yet.The text was updated successfully, but these errors were encountered: