Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for plot_taxonomy_annotate_ts_alluvial(), add a show_tax argument that allows the user to control which taxa are given alluvial ribbons #40

Open
taylorreiter opened this issue Nov 16, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@taylorreiter
Copy link
Member

motivated by a suggestion by @elizabethmcd in #37 and inspired by show_tax in ampvis2 https://kasperskytte.github.io/ampvis2/articles/ampvis2.html

How the function works right now is it uses a fraction_threshold (by default, 0.01, or 1%) -- if a lineage is present in any of the time series at 1% or greater, it gets an alluvial ribbon in the plot. The user can change the fraction_threshold to anything they want it to be. Anything that does not get an alluvial ribbon gets automatically clumped into "other" via a process implemented in the function.

I like the idea of tax_show. This would allow users to either provide a list of taxa to tax_show or use fraction_threshold.

@taylorreiter taylorreiter added the enhancement New feature or request label Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant