Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow users to choose to name from filename or name from query name when plotting things that have multiple samples #54

Open
taylorreiter opened this issue Jan 3, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@taylorreiter
Copy link
Member

because some people won't use the --name flag in sketch and it will be empty

@taylorreiter taylorreiter added enhancement New feature or request release 1.0 Do before first release and removed release 1.0 Do before first release labels Jan 3, 2023
@taylorreiter
Copy link
Member Author

Looking at this more in depth, it's going to be a pretty big lift/add a lot of complexity to the code that I'm not sure is worth it at the moment. What I'm going to do instead is add explicit instructions to the vignette that this is how the plots are built as well as an example of how to add query name from filename or whatever else when it isn't already there.

Although...thinking about this more, I could make a make_query_name() function for all of the read*() functions, built from something like basename(filename), and add using that as an optional param in all of the read functions.

so it would look something like this:

read_taxonomy_annotate(file = Sys.glob("path/to/my/results/*with-lineages.csv"), calculate_query_name = T)

going to think on it a little longer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant