Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closeOnSelect is only respected when singleSelect #9

Open
rvion opened this issue Feb 9, 2022 · 2 comments
Open

closeOnSelect is only respected when singleSelect #9

rvion opened this issue Feb 9, 2022 · 2 comments

Comments

@rvion
Copy link

rvion commented Feb 9, 2022

could closeOnSelect also be resepected with multiselect ?

I'd like to keep the ability to have multiple option selected, while simultaneously closing the popup after each select, because I believe most users will only want one value. Since the dropdown is hiding contents below, closing instantly avoid users to have to move the mouse away, and click once.

looking at:

if (closeOnSelect && singleSelect) {

I can't think of any strong reason to restrict this option in the case of multiSelect.

@rvion
Copy link
Author

rvion commented Feb 9, 2022

and thanks for making this library open source 👍 !

@Arif-un
Copy link
Owner

Arif-un commented Feb 11, 2022

Good point @rvion, usually a single select need this prop after selecting an option, but in multi-select users need to open the options panel. By default it's true but it should be false.
Thanks for notify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants