Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup 7 #102

Merged
merged 6 commits into from
Nov 22, 2023
Merged

Cleanup 7 #102

merged 6 commits into from
Nov 22, 2023

Conversation

MasanoriKanamaru
Copy link
Member

Removed ENABLE_JLD

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ae414e8) 93.43% compared to head (ea017e9) 93.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
+ Coverage   93.43%   93.84%   +0.41%     
==========================================
  Files          10       10              
  Lines         655      650       -5     
==========================================
- Hits          612      610       -2     
+ Misses         43       40       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hyrodium hyrodium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes in this PR look good to me. Additionaly, could you please update Project.toml and .gitignore etc. to remove JLD-related things?

@MasanoriKanamaru MasanoriKanamaru merged commit b7cd460 into main Nov 22, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants