Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms: styles aren’t added to the editor styles when the site editor nav is open #41276

Open
simison opened this issue Jan 23, 2025 · 4 comments
Labels
[Block] Contact Form Form block (also see Contact Form label) [Feature] Forms Blocks Blocks designed to streamline user input and engagement, such as contact, newsletter sign-ups, etc. [Package] Forms [Pri] Normal [Status] Auto-allocated Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@simison
Copy link
Member

simison commented Jan 23, 2025

In the site editor, styles are present for forms:

Image

But not when opening the styles sidebar:

Image

E.g. we lose the font weight on labels etc.

Slack thread p1737618017079479-slack-C02A76B714Z

@simison simison added [Block] Contact Form Form block (also see Contact Form label) [Feature] Forms Blocks Blocks designed to streamline user input and engagement, such as contact, newsletter sign-ups, etc. [Package] Forms [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended labels Jan 23, 2025
@simison
Copy link
Member Author

simison commented Jan 23, 2025

My first instinctive place to look would be how we hve block.json v3 which AFAIK allows blocks to render in iframe (ref), but we also also register settings with custom registerJetpackBlock in editor.js (so kind of duplicate):

import { name, settings } from '.';
registerJetpackBlock( name, settings, childBlocks );

@monsieur-z I remember you worked on adding block.json support to all blocks, but that there were some blocks with translation issues and the block.json had to be partially reverted for those. Were there any issues with Forms block?

@supernovia
Copy link

📌 REPRODUCTION RESULTS

  • Tested on Atomic – Uncertain

📌 ACTIONS

  • Requested author feedback

📌 Message to Author
@simison do you need PA triaging on this? If not, feel free to mark it Triaged.

If you do want us to scrub this, I wasn't clear whether you were talking about the sites styles or styles from the theme, but for what it's worth, when I changed the style of the form, it was consistent between the editor and site editor.

Image Image

@supernovia supernovia moved this from Needs Triage to In Triage in Automattic Prioritization: The One Board ™ Jan 23, 2025
@monsieur-z
Copy link
Contributor

@monsieur-z I remember you worked on adding block.json support to all blocks, but that there were some blocks with translation issues and the block.json had to be partially reverted for those. Were there any issues with Forms block?

Not that I recall. The block.json commit history seems to confirm that.

We identified an issue that looks somewhat similar with the Slideshow, if that can help generate some insights.

@simison
Copy link
Member Author

simison commented Jan 23, 2025

@simison do you need PA triaging on this? If not, feel free to mark it Triaged.

@supernovia nope, thanks! I'm tracking bugs for the Forms product on its own list currently and it's working fine right now.

@jeherve jeherve moved this from In Triage to Triaged in Automattic Prioritization: The One Board ™ Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Contact Form Form block (also see Contact Form label) [Feature] Forms Blocks Blocks designed to streamline user input and engagement, such as contact, newsletter sign-ups, etc. [Package] Forms [Pri] Normal [Status] Auto-allocated Triaged [Type] Bug When a feature is broken and / or not performing as intended
Projects
Development

No branches or pull requests

5 participants