-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZeroFox Solution: Fix project structure for Data Connector deployment #10411
Conversation
Hi @v-sudkharat, we created the PR as requested |
6dc20ff
to
3053ed3
Compare
Hey @v-sudkharat |
@DNRRomero, I just checked the updated zip file and found that, Inside the zip there are sub-folder is created and due to that the function apps do not get displayed.
Expected : Below zi there is not subfolder added - |
Hey @v-sudkharat given your instructions, I was able to deploy our data connectors, thank you! |
Hey @DNRRomero, The changes look good now. Could you please re-package this solution and commit the into this PR. After successfully connected the connector, please add screenshot link below :- And for azure functions, need to add screenshots with function app working successfully. Thanks! |
Hi @v-sudkharat I re submitted the changes you requested and, while trying to re deploy my main template for testing I received the following error |
884b08c
to
8cb44de
Compare
Hi @v-sudkharat I have all connectors working, can we sync? |
Hi @v-sudkharat |
Hey @DNRRomero, Thanks for the update, I will review the content, and can we block time on 21-05-2024 for a sync? |
Hey @v-sudkharat , can it be the 20th? or better yet some day this week? the 21st is a holiday in my country |
@DNRRomero, ok, I will send an invite over mail. |
Hi @DNRRomero, please revert the changes for below highlighted solution folder :- |
Hi @DNRRomero, Is function app started received logs for remaining data types? |
Hi @DNRRomero, We are still waiting for your response. Thanks! |
Hi @v-sudkharat, so far the rest of the connectors have not shown up as connected. |
@DNRRomero, Could you please check for the Invocation logs in functions which not show as connected, and if logs are receiving the into the LAW and it still not show as connected then, need to check for Connectivity criteria inside of function app deploy file, |
Hi @DNRRomero, Any update for logs for function app? |
Hi @v-sudkharat bI saw the logs and connectivity criteria and they are all standard for all connectors, could it be that not all logs are appearing in application insights? |
@DNRRomero, It should. Can you commit latest changes and let me know so i can review it. |
Hi @v-sudkharat any chance we could meet? I've been trying to identify the issue but have not made much progress |
@DNRRomero, Sure. we can connect. Meantime can I have demo credentials from your end to investigate the function app from my end. |
@DNRRomero, waiting for your response. |
Hi @v-sudkharat I sent you credentials over email a few days ago, also scheduled a meeting |
Hi @v-sudkharat given what we discussed today, I added some changes that should fix some of the issues we have encountered so far, any other issues that may appear are related to our internal API and should be fixed under another PR upon further investigation! |
Hi @DNRRomero, Thanks for adding changes. Kindly check on below few points : -
while testing remaining of them, found that the Testing Account provided to me is does not have the required permissions to get the data: Could you please check updated connector by your Account which have the required access and data into it. And share the successfully connected screenshots with us. Please update this branch from master. Thanks! |
hey @v-sudkharat I added the changes requested |
@DNRRomero, Great. Changes looks good now. Approving the PR and proceeding to Merging it. |
Hi @v-sudkharat no comments on my side, is there anything left for the PR merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good
@DNRRomero, We have merged the PR. Thanks! |
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present: