Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMBA consumer guide without the use of a public fork in GitHub #354

Open
1 task done
MilesCameron-DMs opened this issue Oct 1, 2024 · 5 comments
Open
1 task done
Assignees
Labels
documentation Improvements or additions to documentation Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern question Further information is requested

Comments

@MilesCameron-DMs
Copy link

MilesCameron-DMs commented Oct 1, 2024

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Description

Hi guys,

I have read through the wiki pages and found conflicting information around consumption of this repo.

For example on github.io page it states for Deploy with GitHub Actions "To start, you can either download a copy of the parameter file or clone/fork the repository."

On the GitHub repo it states "Fork this repo to your own GitHub organization, you should not create a direct clone of the repo"

Ultimately enterprise companies may not desire or will be prevented by GitHub policy from publishing a public repository in an org.

With that in mind, what would be the approach with the aim of consuming this repo, keeping it up to date and ensuring you can use GitHub processes i.e. not PowerShell, the portal or the CLI.

Please can this be covered somewhere? Apologies if it has but i have searched and scrolled through most of the site pages and cant see anything consistent or thorough which will ultimately hamper adoption of all the useful work you guys are doing.

@MilesCameron-DMs MilesCameron-DMs added the question Further information is requested label Oct 1, 2024
@Brunoga-MS Brunoga-MS added documentation Improvements or additions to documentation Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern labels Oct 2, 2024
@Brunoga-MS
Copy link
Contributor

Hello @MilesCameron-DMs ,
thanks for your feedback. Our official documentation is the one located at the Azure Monitor Baseline Alerts site, which is basically the githib.io site you mentioned. I really would like to encourage you to only refer to that one.

As per your question, cloning or forking the repo is only required if you need to customize policy definitions, policy set definitons or policy assignments based on your needs. Conversely, you can just consume the official repo, which is maintained by the AMBA team, as it is with no need to clone/fork it. You only need to download and customize the parameter file and to refer to it during the deployment. As an alternative, to speed up and ease the deployment, it is also possible to use the Deploy via the Azure Portal (Preview), which just requires you to input some information leveraging the default values (the ones contained in the parameter files provided in the repo) for alert implementation.

We will take care of clarifying the above in our documentation as soon as possible.

Hope that helps.

Thanks,
Bruno.

@Brunoga-MS Brunoga-MS self-assigned this Oct 2, 2024
@MilesCameron-DMs
Copy link
Author

MilesCameron-DMs commented Oct 2, 2024

Thanks @Brunoga-MS

I am finding the wiki pages difficult to consume as they dont appear to flow together well. I am sure the information is there :)

I was expecting a GitHub Action to update the repo and then do a release but it looks like there is a process for deploying and then a separate process for updating.

If we do a manual deployment my next question would be how do we maintain and ensure we keep up to date as its not clear from Update to new releases pages.

For example all of the pages mention running PowerShell scripts but they dont tell you what the PowerShell scripts do and none of them suggest they are performing an update.

Apologies but there is a lot of assumed knowledge/experience in these pages that makes them difficult to follow.

For example on this page:

https://azure.github.io/azure-monitor-baseline-alerts/patterns/alz/UpdateToNewReleases/Update_to_release_2024-09-02/

  • it only has a Pre update actions section - no update actions section
  • It uses a PowerShell script named ./Start-AMBAPolicyInitiativesAndAssignmentsCleanup.ps1 This does not suggest an update but the article ends with this. What does that script do?

Although this information may be somewhere else, it is very difficult and time consuming to follow.

PS how do you do an update? 😆

@Brunoga-MS
Copy link
Contributor

Hello @MilesCameron-DMs ,
I definitely hear you. We will try to make the update documentation more clear. In the meantime I hope the following summary will help:

  1. Check the general update guidance at https://azure.github.io/azure-monitor-baseline-alerts/patterns/alz/UpdateToNewReleases/#steps-to-update-to-the-latest-release (which also contains the steps below)
  2. If you are using your fork/clone, make sure it is aligned with the official repo
  3. Make sure the parameter file structure is aligned with the one in the official repo
  4. Check the update to release xxx guidance to see if there's any pre-update step required. For instance, because of a breaking change, before updating to release 2024-09-02 you need to remove all existing policy and policy assignments using the provided script.
  5. Deploy the latest version using your preferred method
  6. Check the update to release xxx guidance to see if there's any pre-update step required. For instance, after updating to release 2024-04-12 you need to remove existing notification assets using the provided script.
  7. Run the remediation using the provided script

As a side note, updating your own fork/clone, is not something we can manage. We only ensure our original repo is up to date. Hence, is you use it , or our releases, as pointers for your deployment, you will always get the latest version.

Thanks,
Bruno.

@MilesCameron-DMs
Copy link
Author

Thanks @Brunoga-MS - appreciate you getting back to me.

@Brunoga-MS
Copy link
Contributor

Hello @MilesCameron-DMs ,
I just found out that we have an FAQ entry (Can I use AMBA-ALZ without cloning/forking a GitHub repository) which might contain the guidance you area looking at. Could you please check if it is ok or there's the need for more guidance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants