Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Reading Fabric Properties safely #98

Open
cgettys-microsoft opened this issue Nov 15, 2024 · 0 comments
Open

Support Reading Fabric Properties safely #98

cgettys-microsoft opened this issue Nov 15, 2024 · 0 comments

Comments

@cgettys-microsoft
Copy link
Contributor

I would find it very useful to have a higher level wrapper over IFabricPropertyManagementClient
Covering at least:

  • BeginGetProperty/EndGetProperty and/or BeginGetPropertyMetadata/EndGetPropertyMetadata
    And possibly also
  • BeginEnumerateProperties/EndEnumerateProperties
    The other methods (e.g. all the put and Create and Delete and Name ones) are interesting in a general sense, but I don't personally have any immediate use case for them.

Ideally, I want to avoid a tokio dependency being required for these, but we'll see whether that makes any sense.
I'll attempt this myself, but thought I'd raise an issue to track it as well.

youyuanwu pushed a commit that referenced this issue Dec 20, 2024
Ideally, almost no code would have to care about async vs sync, or
whether the executor is tokio or something else.
This may be a impractical goal, but it would certainly be nice.

I noticed that some bits of the sync module do not require tokio_async,
and may be useful to me implementing a safe synchronous (from the Rust
language feature perspective, anyway) version of BeginGetProperty et
cetera (see issue
#98 ). 
Whether such a sync API is useful to mssf_core, I'm not sure, but right
now, my particular use case does not need tokio here, and it's a heavy
dependency.

Reorganize code to address some TODOs and increase how much of the code
can compile without tokio.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant