Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEAUTi: missing Tree prior parameters when switching between templates #32

Closed
jugne opened this issue Sep 23, 2024 · 2 comments
Closed

Comments

@jugne
Copy link
Contributor

jugne commented Sep 23, 2024

When switching between prior templates of BDSky, Tree parameters are not updated correctly.

To reproduce with version 2.7.7:

  • first select Birth Death Skyline Multi Rho template and expand Tree panel.
  • then select Birth Death Skyline Contemporary template, notice that Rho Sampling Times in Tree panel disappear (this is correct behaviour)
  • go back to the Birth Death Skyline Multi Rho template. The Rho Sampling Times parameter in Tree panel does not appear again, which it should.

Coalescent templates seem to handle switching correctly, maybe that helps to narrow it down. Coalescent handles it because the different parameterisations are in separate classes.

@jugne
Copy link
Contributor Author

jugne commented Sep 23, 2024

This is due to different parameters in suppressInputs for different templates. Could be fixed if using ParameterizedBirthDeathSkylineModel instead of BirthDeathSkylineModel.

Possibly there is another workaround..

@jugne
Copy link
Contributor Author

jugne commented Sep 26, 2024

Fixed on BEAUTi side by CompEvol/BeastFX#89

@jugne jugne closed this as completed Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant