diff --git a/Components/AudioPanel.cpp b/Components/AudioPanel.cpp index a3e243fe..4964e1a8 100644 --- a/Components/AudioPanel.cpp +++ b/Components/AudioPanel.cpp @@ -600,7 +600,7 @@ AudioPanel::getOrbit(void) const return this->fcDialog->getOrbit(); } -// Overriden getters +// Overridden getters bool AudioPanel::getRecordState(void) const { @@ -613,7 +613,7 @@ AudioPanel::getRecordSavePath(void) const return this->ui->savePath->text().toStdString(); } -// Overriden methods +// Overridden methods Suscan::Serializable * AudioPanel::allocConfig(void) { diff --git a/Components/DataSaverUI.cpp b/Components/DataSaverUI.cpp index 8dc61c51..ea157265 100644 --- a/Components/DataSaverUI.cpp +++ b/Components/DataSaverUI.cpp @@ -150,7 +150,7 @@ DataSaverUI::~DataSaverUI() } -// Overriden methods +// Overridden methods Suscan::Serializable * DataSaverUI::allocConfig(void) { diff --git a/Components/DopplerDialog.cpp b/Components/DopplerDialog.cpp index a1bf56d1..24beac7e 100644 --- a/Components/DopplerDialog.cpp +++ b/Components/DopplerDialog.cpp @@ -205,7 +205,7 @@ DopplerDialog::onSave(void) QMessageBox::warning( this, "Cannot open file", - "Cannote save file in the specified location. Please choose " + "Cannot save file in the specified location. Please choose " "a different location and try again.", QMessageBox::Ok); } else { diff --git a/Components/PanoramicDialog.cpp b/Components/PanoramicDialog.cpp index 67f5f9be..1bd5f5ec 100644 --- a/Components/PanoramicDialog.cpp +++ b/Components/PanoramicDialog.cpp @@ -849,7 +849,7 @@ PanoramicDialog::refreshGains(Suscan::Source::Device &device) } } -// Overriden methods +// Overridden methods Suscan::Serializable * PanoramicDialog::allocConfig(void) { @@ -1110,7 +1110,7 @@ PanoramicDialog::onExport(void) QMessageBox::warning( this, "Cannot open file", - "Cannote save file in the specified location. Please choose " + "Cannot save file in the specified location. Please choose " "a different location and try again.", QMessageBox::Ok); } else { diff --git a/Misc/GenericDataSaver.cpp b/Misc/GenericDataSaver.cpp index 997cf91b..fa4a96d0 100644 --- a/Misc/GenericDataSaver.cpp +++ b/Misc/GenericDataSaver.cpp @@ -1,5 +1,5 @@ // -// GenericDataSaver.h: save hight bandwidth data +// GenericDataSaver.h: save height bandwidth data // Copyright (C) 2019 Gonzalo José Carracedo Carballal // // This program is free software: you can redistribute it and/or modify diff --git a/README.md b/README.md index 01a1bcbd..b80f03bc 100644 --- a/README.md +++ b/README.md @@ -6,7 +6,7 @@ SigDigger is a free digital signal analyzer for GNU/Linux and macOS, designed to ## Wait, why does it look like Gqrx? Because I'm a terrible person. Also, because after dealing with a lot of software of the sort, I realized that Gqrx had the best UI of them all: minimalistic yet operative. Earlier versions of the UI were somewhat different, but after a lot of debugging I came to the conclusion that it would be better off if I just tried to mimic existing (and successful) software, reducing the learning curve to the new feature set. -You may notice that the spectrum widget looks a lot like Gqrx's. This is because the specturm widget is actually Gqrx's with minimal modifications (like support for configurable Waterfall palettes). I tried to code my own Waterfall widget in Suscan and Xorg ended up hogging the CPU, so I'm not reinventing the wheel anymore: I decided to extend the existing Gqrx's Plotter widget so it fits SigDigger's set of features. +You may notice that the spectrum widget looks a lot like Gqrx's. This is because the spectrum widget is actually Gqrx's with minimal modifications (like support for configurable Waterfall palettes). I tried to code my own Waterfall widget in Suscan and Xorg ended up hogging the CPU, so I'm not reinventing the wheel anymore: I decided to extend the existing Gqrx's Plotter widget so it fits SigDigger's set of features. Apart from the UI layout and the plotter widget, SigDigger bears little resemblance to Gqrx: Gqrx depends on GNU Radio, while SigDigger is a Qt5 frontend for Suscan. The DSP chains are totally different and Suscan's thread model is optimized for a very specific set of tasks. @@ -16,7 +16,7 @@ SigDigger depends on three different projects: **Sigutils**, **Suscan** and **Su * Sigutils build instructions can be found [here](https://github.com/BatchDrake/sigutils/blob/master/README.md). * Suscan build instructions can be found [here](https://github.com/BatchDrake/suscan/blob/master/README.md). -Before even attempting to run `cmake`, you may want to decide which branch you want to build. If you build from `master` (this is the default for SigDigger and all its dependencies), you will get a fresh executable of the latest stable release of SigDigger. If you build from `develop` (by running `git fetch origin develop` and `git checkout develop` in all four projects, right after `git clone`), you will get SigDigger with the latest experimental features. Plese note that the `develop` branch is still under validation, so if you want to build from it, expect bugs, inconsistent behaviors and crashes. Any feedback is welcome though. +Before even attempting to run `cmake`, you may want to decide which branch you want to build. If you build from `master` (this is the default for SigDigger and all its dependencies), you will get a fresh executable of the latest stable release of SigDigger. If you build from `develop` (by running `git fetch origin develop` and `git checkout develop` in all four projects, right after `git clone`), you will get SigDigger with the latest experimental features. Please note that the `develop` branch is still under validation, so if you want to build from it, expect bugs, inconsistent behaviors and crashes. Any feedback is welcome though. After successfully building Sigutils and Suscan, you can now proceed to build **SuWidgets**. SuWidgets is Qt 5 graphical library containing all SigDigger's custom widgets. In order to build it, ensure you have the Qt 5 (>= 5.9) development framework installed in your system and then run: diff --git a/Scripts/build.sh b/Scripts/build.sh index 78a6cc3c..0c96fcc6 100755 --- a/Scripts/build.sh +++ b/Scripts/build.sh @@ -43,5 +43,5 @@ try "Moving files out of /usr..." mv "$DEPLOYROOT"/usr/* "$DEPLOYROOT" try "Remove empty /usr..." rmdir "$DEPLOYROOT"/usr try "Setting permissions to wrapper scripts..." chmod a+x "$DEPLOYROOT"/SigDigger "$DEPLOYROOT"/suscli echo -echo "Done. SigDigger compiled succesfully in $DEPLOYROOT" +echo "Done. SigDigger compiled successfully in $DEPLOYROOT" diff --git a/Suscan/Library.cpp b/Suscan/Library.cpp index cb837085..cc8ad389 100644 --- a/Suscan/Library.cpp +++ b/Suscan/Library.cpp @@ -362,7 +362,7 @@ Singleton::init_bookmarks(void) bm.info.color = QColor(QString::fromStdString(list[i].getField("color").value())); try { - // try parse extended informations + // try parse extended information std::string lowFreqCut = list[i].getField("low_freq_cut").value(); std::string highFreqCut = list[i].getField("high_freq_cut").value(); bm.info.modulation = QString::fromStdString(list[i].getField("modulation").value()); diff --git a/UIMediator/UIMediator.cpp b/UIMediator/UIMediator.cpp index 7ec3ed3a..4575d008 100644 --- a/UIMediator/UIMediator.cpp +++ b/UIMediator/UIMediator.cpp @@ -987,7 +987,7 @@ UIMediator::onTriggerExport(bool) QMessageBox::warning( this->ui->main->centralWidget, "Cannot open file", - "Cannote save file in the specified location. Please choose " + "Cannot save file in the specified location. Please choose " "a different location and try again.", QMessageBox::Ok); } else { diff --git a/include/AppConfig.h b/include/AppConfig.h index a6960dbb..8e29c1f8 100644 --- a/include/AppConfig.h +++ b/include/AppConfig.h @@ -77,7 +77,7 @@ namespace SigDigger { void loadDefaults(void); - // Overriden methods + // Overridden methods void deserialize(Suscan::Object const &conf) override; Suscan::Object &&serialize(void) override; }; diff --git a/include/AudioPanel.h b/include/AudioPanel.h index c9809236..707b226a 100644 --- a/include/AudioPanel.h +++ b/include/AudioPanel.h @@ -52,7 +52,7 @@ namespace SigDigger { std::string satName = "ISS (ZARYA)"; std::string tleData = ""; - // Overriden methods + // Overridden methods void deserialize(Suscan::Object const &conf) override; Suscan::Object &&serialize(void) override; }; @@ -111,7 +111,7 @@ namespace SigDigger { void notifyOrbitReport(Suscan::OrbitReport const &); void notifyDisableCorrection(void); - // Overriden setters + // Overridden setters void setRecordSavePath(std::string const &) override; void setSaveEnabled(bool enabled) override; void setCaptureSize(quint64) override; @@ -133,11 +133,11 @@ namespace SigDigger { SUFLOAT getSquelchLevel(void) const; Suscan::Orbit getOrbit(void) const; - // Overriden getters + // Overridden getters bool getRecordState(void) const override; std::string getRecordSavePath(void) const override; - // Overriden methods + // Overridden methods Suscan::Serializable *allocConfig(void) override; void applyConfig(void) override; diff --git a/include/ColorConfig.h b/include/ColorConfig.h index 7eb1dcac..118a22e7 100644 --- a/include/ColorConfig.h +++ b/include/ColorConfig.h @@ -46,7 +46,7 @@ namespace SigDigger { ColorConfig(); ColorConfig(Suscan::Object const &conf); - // Overriden methods + // Overridden methods void loadDefaults(void); void deserialize(Suscan::Object const &conf) override; Suscan::Object &&serialize(void) override; diff --git a/include/DataSaverUI.h b/include/DataSaverUI.h index cac0017c..72f8f2c7 100644 --- a/include/DataSaverUI.h +++ b/include/DataSaverUI.h @@ -31,7 +31,7 @@ namespace SigDigger { public: std::string path; - // Overriden methods + // Overridden methods void deserialize(Suscan::Object const &conf) override; Suscan::Object &&serialize(void) override; }; @@ -57,7 +57,7 @@ namespace SigDigger { bool getRecordState(void) const override; std::string getRecordSavePath(void) const override; - // Other overriden methods + // Other overridden methods Suscan::Serializable *allocConfig(void) override; void applyConfig(void) override; diff --git a/include/FftPanel.h b/include/FftPanel.h index 7b0948de..641c905f 100644 --- a/include/FftPanel.h +++ b/include/FftPanel.h @@ -58,7 +58,7 @@ namespace SigDigger { int zoom = 1; - // Overriden methods + // Overridden methods void deserialize(Suscan::Object const &conf) override; Suscan::Object &&serialize(void) override; }; @@ -169,7 +169,7 @@ namespace SigDigger { void setSampleRate(unsigned int); void setWindowFunction(enum Suscan::AnalyzerParams::WindowFunction func); - // Overriden methods + // Overridden methods Suscan::Serializable *allocConfig(void) override; void applyConfig(void) override; diff --git a/include/GuiConfig.h b/include/GuiConfig.h index 0457ad7e..cacf8b6f 100644 --- a/include/GuiConfig.h +++ b/include/GuiConfig.h @@ -35,7 +35,7 @@ namespace SigDigger { GuiConfig(); GuiConfig(Suscan::Object const &conf); - // Overriden methods + // Overridden methods void loadDefaults(void); void deserialize(Suscan::Object const &conf) override; Suscan::Object &&serialize(void) override; diff --git a/include/InspectorPanel.h b/include/InspectorPanel.h index 4430297f..886567fa 100644 --- a/include/InspectorPanel.h +++ b/include/InspectorPanel.h @@ -42,7 +42,7 @@ namespace SigDigger { int paletteContrast; bool precise = false; - // Overriden methods + // Overridden methods void deserialize(Suscan::Object const &conf) override; Suscan::Object &&serialize(void) override; }; @@ -118,7 +118,7 @@ namespace SigDigger { bool getPrecise(void) const; enum State getState(void) const; - // Overriden methods + // Overridden methods Suscan::Serializable *allocConfig(void) override; void applyConfig(void) override; diff --git a/include/PanoramicDialog.h b/include/PanoramicDialog.h index 2385e807..d17a3bd3 100644 --- a/include/PanoramicDialog.h +++ b/include/PanoramicDialog.h @@ -61,7 +61,7 @@ namespace SigDigger { SUFLOAT getGain(std::string const &dev, std::string const &name) const; void setGain(std::string const &dev, std::string const &name, SUFLOAT val); - // Overriden methods + // Overridden methods void deserialize(Suscan::Object const &conf) override; Suscan::Object &&serialize(void) override; }; @@ -140,7 +140,7 @@ namespace SigDigger { void setBannedDevice(QString const &); void saveConfig(void); - // Overriden methods + // Overridden methods Suscan::Serializable *allocConfig(void) override; void applyConfig(void) override; diff --git a/include/SourcePanel.h b/include/SourcePanel.h index 7ccc4e0a..4ed2c656 100644 --- a/include/SourcePanel.h +++ b/include/SourcePanel.h @@ -42,7 +42,7 @@ namespace SigDigger { unsigned int throttleRate = 196000; - // Overriden methods + // Overridden methods void deserialize(Suscan::Object const &conf) override; Suscan::Object &&serialize(void) override; }; @@ -177,7 +177,7 @@ namespace SigDigger { float getBandwidth(void) const; float getPPM(void) const; - // Overriden methods + // Overridden methods Suscan::Serializable *allocConfig(void) override; void applyConfig(void) override; diff --git a/include/UIMediator.h b/include/UIMediator.h index 5628b0e2..3a46546d 100644 --- a/include/UIMediator.h +++ b/include/UIMediator.h @@ -179,7 +179,7 @@ namespace SigDigger { void setSourceTimeEnd(struct timeval const &); void setTimeStamp(struct timeval const &); - // Overriden methods + // Overridden methods Suscan::Serializable *allocConfig() override; void applyConfig(void) override; diff --git a/ui/AboutDialog.ui b/ui/AboutDialog.ui index 93481a67..c33539ad 100644 --- a/ui/AboutDialog.ui +++ b/ui/AboutDialog.ui @@ -56,7 +56,7 @@ p, li { white-space: pre-wrap; } <p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; font-size:9pt;"><br /></p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;"><span style=" font-size:9pt;">Multiple UX improvements were possible thanks to Bartek's tips (</span><a href="https://github.com/BSAsecure"><span style=" font-size:9pt; text-decoration: underline; color:#0986d3;">https://github.com/BSAsecure</span></a><span style=" font-size:9pt;">). Many features and UI enhancements were suggested by cemaxecuter (</span><a href="https://github.com/BSAsecure"><span style=" font-size:9pt; text-decoration: underline; color:#0986d3;">https://cemaxecuter.com/</span></a><span style=" font-size:9pt;">) during his extensive testing of the application in DragonOS.</span></p> <p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; font-size:9pt;"><br /></p> -<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;"><span style=" font-size:9pt;">This release also cointains bugfixes by Mehdi Asgari and Kai Wolf, as well as frequency navigation improvements and bookmark handling enhancements by Jaroslav Šafka (</span><a href="https://github.com/jedi7"><span style=" font-size:9pt; text-decoration: underline; color:#007af4;">https://github.com/jedi7</span></a><span style=" font-size:9pt;">)</span></p> +<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;"><span style=" font-size:9pt;">This release also contains bugfixes by Mehdi Asgari and Kai Wolf, as well as frequency navigation improvements and bookmark handling enhancements by Jaroslav Šafka (</span><a href="https://github.com/jedi7"><span style=" font-size:9pt; text-decoration: underline; color:#007af4;">https://github.com/jedi7</span></a><span style=" font-size:9pt;">)</span></p> <p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; font-size:9pt;"><br /></p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;"><span style=" font-size:9pt;">Unsigned 8-bit raw file support, FreeBSD compatibility, benchmarks, bugfixes and several design ideas were possible thanks to </span><span style=" font-size:9pt; font-weight:600;">Josef &quot;Jeff&quot; Sipek</span><span style=" font-size:9pt;"> (</span><a href="https://josefsipek.net/"><span style=" font-size:9pt; text-decoration: underline; color:#007af4;">https://josefsipek.net/</span></a><span style=" font-size:9pt;">)</span></p> <p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; font-size:9pt;"><br /></p> diff --git a/ui/RMSViewTab.ui b/ui/RMSViewTab.ui index 41a93293..07fb3489 100644 --- a/ui/RMSViewTab.ui +++ b/ui/RMSViewTab.ui @@ -48,7 +48,7 @@ - Toggle logaritmic scale + Toggle logarithmic scale dB