Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a 'byline' or 'contributors' property #7

Open
phillipadsmith opened this issue Aug 14, 2016 · 1 comment
Open

Provide a 'byline' or 'contributors' property #7

phillipadsmith opened this issue Aug 14, 2016 · 1 comment
Assignees

Comments

@phillipadsmith
Copy link
Member

Every client is going to have to implement a function to create a string from the author names, as well as having to look up the proper name from the API once for each author in the authors property of the module.

Instead, this should be written once in the API code and provided as a property of the module object, e.g,:

byline: Jane Doe and John Doe

Or
byline: Jane Doe, John Doe, and Janice Doe

Or

byline: Jane Doe

Thoughts?

@adrian-the-git
Copy link
Contributor

Alright. It's clear to me that the content loader needs some kind of early-stage translated strings because it doesn't currently have a good way to load the necessary and/y/و strings. Relying on one of the text docs makes the whole thing kind of brittle.

Anyhow I've put a hacked solution in place, but don't parse this byline key because it could potentially list a missing author or contain a typo which the normal relationship-munging code would catch. Really missing relational dbs! And I hate SQL the same as anyone! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants