Receiving notifications with dynamic lengths

[JoshuaFoundry]

I'm wanting to receive notifications from ADS logs on port 100. When I create a notification with a max length of 1024 I get this error message: "Warning: Notification sample size: 101 doesn't match: 1024"

The code that generates this error:

ADS/AdsLib/standalone/NotificationDispatcher.cpp

Line 76 in 20d4a67

LOG_WARN("Notification sample size: " << size << " doesn't match: " << notification->Size());

It looks for the notification in the buffer to be the same size as what was defined in the notification. Instead of:
if (size != notification->Size())
could we do:
if (size > notification->Size())
or something else?

Thanks!

[pbruenn]

Hi @JoshuaFoundry, sorry for taking to long, I got distracted. Here is a branch which should achieve what you want: https://github.com/Beckhoff/ADS/tree/patrickbr/variable-sized-notifications. However, at the moment we have no intention to merge this to master, since it is quite a big change only necessary for the old AMSPORT_LOGGER. maybe if more usecases arise, but for now I prefer the more static notification size.