Timestamps missing for times after midnight the next day

[macourteau]

Departure and arrival times are sometimes after midnight the next day (e.g. '24:03:30'). Any time value that is after midnight the next day has a null matching <field>_timestamp field, likely because of this check:

node-gtfs/src/lib/utils.ts

Lines 79 to 86 in a124a12

	if (
	[hours, minutes, seconds].some(isNaN) ||
	hours >= 24 ||
	minutes >= 60 ||
	seconds >= 60
	) {
	return null;
	}

Would it make sense to allow for some amount of time past 24h to make sure these fields don't have null timestamps?

[brendannee]

Thanks for reporting this and pointing to the answer!

I pushed an update that resolves this issue: https://github.com/BlinkTagInc/node-gtfs/releases/tag/4.15.12 - check it out and let me know if it works as expected.