Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] ModernUI and Inline incompatibility #269

Open
elpocoburrito opened this issue Dec 31, 2024 · 1 comment
Open

[Bug] ModernUI and Inline incompatibility #269

elpocoburrito opened this issue Dec 31, 2024 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@elpocoburrito
Copy link

elpocoburrito commented Dec 31, 2024

Inline and ModernUI incompatibility
This is a known bug to both devs, but the issues on both repos shift the blame to the author of the other mod, with no resolutions. Was hoping either or both devs could look into a proper fix, if it actually is possible? If its unreasonable amount of work (which implementing the mixin injector system suggested by Inline dev sounds like it could be) or its just impossible, just close this issue, thanks for your time!

To Reproduce
Install both Inline and ModernUI, on forge or neoforge (possibly other loaders) and it will plain crash during boot.
A suggestion of a band-aid was offered in the issues, of disabling ModernUI's text engine, but that removes my entire reason for using ModernUI, which is a super cool mod that I love, as the game looks so much better with it.

Expected behavior
No crash with both mods.

Environment

  • Mod Version: seems version agnostic but in my case 1.20.1 forge

Issues linked
SamsTheNerd/inline#9
#251

@BloCamLimb
Copy link
Owner

BloCamLimb commented Dec 31, 2024

I have already explicitly stated that theoretically it is not possible to make Inline mod work on Modern Text Engine, but we could add new features equivalent to Inline, or integrate Inline into Modern Text Engine, like rendering items/entities inline with text. Consider making a PR for us.

Source code of Modern Text Engine: https://github.com/BloCamLimb/ModernUI-MC/tree/master/common/src/main/java/icyllis/modernui/mc/text

@BloCamLimb BloCamLimb added the duplicate This issue or pull request already exists label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants