Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement consensus/rpc #16

Closed
gerceboss opened this issue Aug 25, 2024 · 9 comments
Closed

Implement consensus/rpc #16

gerceboss opened this issue Aug 25, 2024 · 9 comments
Assignees

Comments

@gerceboss
Copy link
Contributor

Implement all the files inside consensus/rpc package

@x-senpai-x
Copy link

Assign

@x-senpai-x
Copy link

For mockRpc we need test data (Json files for bootstrap, finality , optimistic and updates) . So should I just implement the other 2 files?

@star-gazer111
Copy link
Member

For mockRpc we need test data (Json files for bootstrap, finality , optimistic and updates) . So should I just implement the other 2 files?

You can generate that testdata just like they did it here in helios

@x-senpai-x
Copy link

so I can just copy this data?

@x-senpai-x
Copy link

also Structs beaconblockdata,UpdateData,FinalityUpdateResponse,OptimisticUpdateResponse etc use data as structs defined in consensus core in helios so should I just assume they will be defined later on in selene and use them by name directly?

@gerceboss
Copy link
Contributor Author

@x-senpai-x, for now, make a new file consensus/consensus_core.go and write the required structs there.

@x-senpai-x
Copy link

x-senpai-x commented Aug 26, 2024

@x-senpai-x, for now, make a new file consensus/consensus_core.go and write the required structs there.
Many of the structs are inter-connected
So I'll have to implement almost the entire consensus core mod.rs
So should I implement it?

@x-senpai-x
Copy link

x-senpai-x commented Aug 26, 2024

also why do we have consensusRpc as struct field ?
Shouldn't we just have rpc in the struct? @gerceboss

gerceboss added a commit that referenced this issue Aug 31, 2024
@star-gazer111
Copy link
Member

Resolved here #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants