Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How are logos/covers treated? #4

Open
hakusaro opened this issue Oct 20, 2013 · 1 comment
Open

How are logos/covers treated? #4

hakusaro opened this issue Oct 20, 2013 · 1 comment

Comments

@hakusaro
Copy link

I'm sorry if I'm missing something, but I'm really not getting how I'm supposed to configure blog logo & cover so that this theme treats them both appropriately.

If I upload a logo and a cover, they're intermixed where I would think a simple square logo would fit. If I upload only a cover or only a logo to prevent overlap, I get even less of a good result.

Here's an example if someone used my avatar twice as the logo:

Even the code doesn't make sense. If I'm reading this right, the logic flow is "if there's a blog cover, display the blog cover and the logo at the same time." Removing one or the other produces interesting results too.

        {{#if @blog.cover}}
            <header class="yarn">
                <a href="{{@blog.url}}">
                <figure class="cover">
                    {{#if @blog.logo}}
                    <img class="yarn__logo" src="{{@blog.cover}}" alt="{{@blog.title}}" />
                    {{else}}!{{/if}}
                    <img class="yarn__cover" src="{{@blog.logo}}" alt="{{@blog.title}}" />
                </figure>
                <span>{{@blog.title}}</span>
                </a>
            </header>
        {{else}}
            <header class="yarn">
                <a href="{{@blog.url}}">
                <figure>!</figure>
                <span>{{@blog.title}}</span>
                </a>
            </header>
        {{/if}}
@BorisKourt
Copy link
Owner

Woops, somehow completely missed the notification for this!

I really need to document this asap. The idea I had is that you can duplicate the feel of the ghost.cat logo by uploading an image as a background (using the blog cover) and an image as the logo (using the blog logo). They are on two layers one is above the other. If you upload a 1:1 aspect ratio png image for the logo it will fit perfectly into the square at any size, any transparency on that will show the 'cover' image.

This was the best way I could think of, as there are no theme settings, to let you create a background + logo combo that you would like.

Hope this makes sense, and I am really sorry for missing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants