Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why using the key and value as the garment features? #12

Open
sunke123 opened this issue Jan 3, 2025 · 1 comment
Open

Why using the key and value as the garment features? #12

sunke123 opened this issue Jan 3, 2025 · 1 comment

Comments

@sunke123
Copy link

sunke123 commented Jan 3, 2025

Hi Boyuan,

Amazing work!
I'm curious about that you select the key and value as the garment features but not the hidden states of the attention block.
Would such a design yield better results?
@BoyuanJiang
Copy link
Owner

The key and value are from hidden states, we did not test directly use hidden states as garment features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sunke123 @BoyuanJiang