Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS Review #77

Closed
mengqi-z opened this issue Jan 6, 2025 · 1 comment
Closed

JOSS Review #77

mengqi-z opened this issue Jan 6, 2025 · 1 comment

Comments

@mengqi-z
Copy link

mengqi-z commented Jan 6, 2025

Hi @lionel42,

Thank you for your submission to JOSS openjournals/joss-reviews#7509. I have few comments on the paper for you to address before we can move to the next phase.

  1. The following references are missing co-author names. Please review all references and ensure that the full list of authors is included.

  2. Citation for "ICON partnership, 2024": According to the official suggested citation from this link https://www.wdc-climate.de/ui/entry?acronym=IconRelease01, "ICON partnership (DWD; MPI-M; DKRZ; KIT; C2SM)" should be treated as a single author entity, not as multiple authors.

  3. There is an extra space after "API documentation" on line 66. Please remove it.

  4. On line 82, the word "Edgar" should be capitalized.

lionel42 added a commit that referenced this issue Jan 7, 2025
@lionel42
Copy link
Collaborator

lionel42 commented Jan 7, 2025

@mengqi-z Thanks for reporting.

I have updated the joss branch with your suggested corrections.

@mengqi-z mengqi-z closed this as completed Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants