Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: CAVEconnectome/CAVEclient
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v7.4.3
Choose a base ref
...
head repository: CAVEconnectome/CAVEclient
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 4 commits
  • 2 files changed
  • 1 contributor

Commits on Dec 20, 2024

  1. Update changelog.md

    kebwi authored Dec 20, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    c0fc8fa View commit details
  2. Update changelog.md

    kebwi authored Dec 20, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    591c0d8 View commit details
  3. Bumped default skeleton version from 3 to 4.

    kebwi committed Dec 20, 2024
    Copy the full SHA
    8a12458 View commit details
  4. Merge pull request #292 from CAVEconnectome/skeletons_v4

    Bumped default skeleton version from 3 to 4.
    kebwi authored Dec 20, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    884309e View commit details
Showing with 6 additions and 3 deletions.
  1. +3 −3 caveclient/skeletonservice.py
  2. +3 −0 docs/changelog.md
6 changes: 3 additions & 3 deletions caveclient/skeletonservice.py
Original file line number Diff line number Diff line change
@@ -495,7 +495,7 @@ def get_skeleton(
self,
root_id: int,
datastack_name: Optional[str] = None,
skeleton_version: Optional[int] = 3,
skeleton_version: Optional[int] = 4,
output_format: Literal[
"dict",
"swc",
@@ -614,7 +614,7 @@ def get_bulk_skeletons(
self,
root_ids: List,
datastack_name: Optional[str] = None,
skeleton_version: Optional[int] = 3,
skeleton_version: Optional[int] = 4,
output_format: Literal[
"dict",
"swc",
@@ -743,7 +743,7 @@ def generate_bulk_skeletons_async(
logging.warning(
"The optional nature of the 'skeleton_version' parameter will be deprecated in the future. Please specify a skeleton version."
)
skeleton_version = -1
skeleton_version = 4

if isinstance(root_ids, np.ndarray):
root_ids = root_ids.tolist()
3 changes: 3 additions & 0 deletions docs/changelog.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
---
title: Changelog
---
## 7.4.3 (December 20, 2024)
- Enabled skeleton client to generate & retrieve the new V4 skeleton format (and all future skeleton versions without necessitating CAVEclient upgrades -- unless the hard-coded default version needs to be continually updated I suppose).

## 7.4.2 (December 18, 2024)
- Eliminated skeleton client skeleton_exists() issue in which passing a large number of root ids would cause a "URI too big" error.