Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full network shutdown #45

Open
PresidentNavalny opened this issue Jul 20, 2019 · 4 comments
Open

Full network shutdown #45

PresidentNavalny opened this issue Jul 20, 2019 · 4 comments
Labels
BugBounty 💵 critical 💀 Emergency situation leading to a complete stop of the blockchain, and the impossibility of carrying

Comments

@PresidentNavalny
Copy link

PresidentNavalny commented Jul 20, 2019

My English is not perfect, so for a better understanding of the problem, after the English description I posted the Russian version of this text because most of the developers are Russian

Describe the bug
Full network shutdown

To Reproduce

Created a smart contract that sends 10-15 transactions to the addresses of other seventeen(17) smart contracts. 10-15 transactions are sent to each of the 17 smart contracts. A total of 236 transactions and 17 recipients. This smart contract "DSR5wLzZsLJMx5gVAqUAiSBV8CjCbUsjvexdxdbxmqfz"
1111
After I created this smart contract, I sent 1 CS to it, this smart contract sent 236 transactions to the addresses of other 17 smart contracts. Then I sent 1CS to the smart contract which was in the list of these 17 smart contracts. After that, the network began to create 1 block in 1-2 minutes and ignore the transactions that I tried to send in the future. in this mode, the network "worked" for 25 minutes and created 22 blocks in 25 minutes. Then she stopped completely.
555
Создал смарт контракт который отправляет на адреса других семнадцати смарт контрактов 10-15 транзакций. На каждый из 17 смарт контрактов отправляется 10-15 транзакций. Всего 236 транзакций и 17 получателей. Вот этот смарт контракт "DSR5wLzZsLJMx5gVAqUAiSBV8CjCbUsjvEXdxDbxMQFz"
После того как я создал этот смарт контракт, я отправил на него 1 CS, этот смарт контракт разослал на адреса других семнадцати смарт контрактов 236 транзакций. Затем я отправил 1CS на смарт контракт который был в списке этих 17 смарт контрактов. После чего сеть стала создавать 1 блок за 1-2 минуты и игнорировать транзакции которые я пытался отправить в дальнейшем. в таком режиме сеть "работала" в течении 25 минут и создала за 25 минут 22 блока. После чего она полностью остановилась.

@PresidentNavalny PresidentNavalny added BugBounty 💵 critical 💀 Emergency situation leading to a complete stop of the blockchain, and the impossibility of carrying labels Jul 20, 2019
@PresidentNavalny
Copy link
Author

In the same way, stopped the Dapsnet network

Smart contract "7eoo8K8WBUx755kKDunnjVET53X1foYx97hmuDN58PzQ"
1010
2020

@tkoen93
Copy link

tkoen93 commented Jul 20, 2019

Your contract has got a negative balance -> https://monitor.credits.com/testnet-r4_2/Account/DSR5wLzZsLJMx5gVAqUAiSBV8CjCbUsjvEXdxDbxMQFz (#20 bug still exists)

Same on devs & dapps net, negative balance.

image

Did not see any new blocks in the log or on the monitor, but node kept on working. Judging my logfile I'd say it's either because it's some kind of safety mechanism in the testnet or because a huge amount of (invalid) transactions are stuck in the network.

@ Developers, some community members are still waiting for an installer of the latest testnet version, some have built the node themselves from the available code here on GitHub. It might be possible that there are different contract-executor.jar versions within the network and the consensus protocol causing this.

Starting your node with an old version of the contract-executor.jar shouldn't be possible (which currently is possible I believe), it will not support all functionalities.

Added some log files in case it's needed
log_6.zip
executor-log-2019-07-19.zip

@PresidentNavalny
Copy link
Author

The negative balance of smart contracts arises militarily, at the moment when it is loaded with “spam” transactions. After all spam transactions are rejected, the balance of the smart contract will return to the correct value. This is a "cosmetic" bug, it is not dangerous judging by my observations

@tkoen93
Copy link

tkoen93 commented Jul 20, 2019

A negative balance should never ever occur, in whatever state it is.

[2019-07-20 04:28:28.312647] [0x00007fe516c09700] [info] Validator: validateNewStateAsSource: reject new_state transaction, initier is out of funds

My logfile as uploaded here;

Added some log files in case it's needed
log_6.zip
executor-log-2019-07-19.zip

contains 813 lines with out of funds. It also mentions they're rejected, but in fact they're stuck, as they're being rejected every time a so called bigbang in the network happens.

@ Developers, starting from line 287963 of my logfile there is a packet of 6928 transactions. In the 7k lines below line 287963 you can see them all being rejected.

[2019-07-20 04:59:03.209643] [0x00007fe516c09700] [debug] Trusted-1: -------> STARTING CONSENSUS #1954338 <------- 
[2019-07-20 04:59:03.213457] [0x00007fe516c09700] [debug] Trusted-1: packet of 6928 transactions inN2cs8ConveyerE
[2019-07-20 04:59:03.213513] [0x00007fe516c09700] [debug] Trusted-1: smart contract packets count 9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BugBounty 💵 critical 💀 Emergency situation leading to a complete stop of the blockchain, and the impossibility of carrying
Projects
None yet
Development

No branches or pull requests

2 participants