Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extinctFilter var to sector forms #1499

Open
camiplata opened this issue Sep 25, 2024 · 9 comments
Open

Add extinctFilter var to sector forms #1499

camiplata opened this issue Sep 25, 2024 · 9 comments
Assignees

Comments

@camiplata
Copy link
Collaborator

camiplata commented Sep 25, 2024

Could it be possible to create different sectors for PBDB base on extant and extinct taxa? As it has one of the highest priorities is adding names from extant taxa (not necessarily wrong) for groups like birds or insects where there are more curated sources.

@mdoering
Copy link
Member

It is sth we could add, yes. But maybe it doesn't have to be such a high priority?

@camiplata
Copy link
Collaborator Author

no, is not a priority. But then I would like to move PBDB towards the end of the priority lists

@camiplata camiplata transferred this issue from CatalogueOfLife/xcol Nov 20, 2024
@camiplata
Copy link
Collaborator Author

Another use case for the feature is IRMNG, as it has many fossil taxa that we would like to add.

CatalogueOfLife/data#737

@mdoering
Copy link
Member

I will add a extinctFilter setting for sectors that accepted the 3 states null/true/false with true only syncing extinct usages.

@camiplata
Copy link
Collaborator Author

@mdoering where can I find the extinctFilter? I looked at the UI and the config file but I'n not sure how to set it up

@camiplata camiplata reopened this Jan 14, 2025
@mdoering mdoering assigned thomasstjerne and unassigned mdoering Jan 15, 2025
@mdoering mdoering added this to the Extended Project Release milestone Jan 15, 2025
@mdoering
Copy link
Member

@camiplata only the UI is missing at this point. While we wait for @thomasstjerne to implement it you could use the API to update some sectors or let me know about the ones you want to be changed and I can do that for you

@mdoering mdoering changed the title more sectors options for adding PBDB Add extinctFilter var to sector forms Jan 16, 2025
@camiplata
Copy link
Collaborator Author

Hi @mdoering, great could you plese help me setting up this two sectors:

@mdoering
Copy link
Member

You can do this by retrieving a sector, modify its content, i.e. add the extinctFilter property above, and PUT it back to the API:

curl -s --user USER:PWD -X GET "https://api.checklistbank.org/dataset/3/sector/58671" > sector.json   
vi sector.json
curl -s --user USER:PWD -X PUT -H "Content-Type: application/json" --data-binary @sector.json "https://api.checklistbank.org/dataset/3/sector/58671"

@mdoering
Copy link
Member

I have updated the 2 sectors above via the API:

% curl -s -X GET "https://api.checklistbank.org/dataset/3/sector/54638" | jq .  
{
  "created": "2024-08-16T19:39:27.078008",
  "createdBy": 728,
  "modified": "2025-01-17T14:26:06.455978",
  "modifiedBy": 101,
  "datasetKey": 3,
  "id": 54638,
  "subjectDatasetKey": 1174,
  "mode": "merge",
  "priority": 127,
  "extinctFilter": true,
  "copyAccordingTo": false,
  "removeOrdinals": false,
  "size": 0
}
curl -s -X GET "https://api.checklistbank.org/dataset/3/sector/58671" | jq .  
{
  "created": "2025-01-17T13:42:57.781129",
  "createdBy": 728,
  "modified": "2025-01-17T14:28:48.098273",
  "modifiedBy": 101,
  "datasetKey": 3,
  "id": 58671,
  "subjectDatasetKey": 2007,
  "mode": "merge",
  "priority": 128,
  "extinctFilter": true,
  "copyAccordingTo": false,
  "removeOrdinals": false,
  "size": 0
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants