Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sim test in devnet-5 branch #7339

Closed
ensi321 opened this issue Jan 9, 2025 · 2 comments
Closed

Fix sim test in devnet-5 branch #7339

ensi321 opened this issue Jan 9, 2025 · 2 comments
Labels
scope-testing Issues for adding test coverage, fixing existing tests or testing strategies. spec-electra 🦒 Issues targeting the Electra spec version

Comments

@ensi321
Copy link
Contributor

ensi321 commented Jan 9, 2025 

          It looks like there is a consensus issue with Lighthouse in our sim tests due to this, need to use a image with the updated minimal preset values. Should not be a blocker to merge this but should figure out a solution (ie. updating LH image) before we merge the devnet-5 branch to unstable

Originally posted by @nflaig in #7309 (comment)
@nflaig
Copy link
Member

nflaig commented Jan 10, 2025

There might be some changes required on how we configure LH in our sim tests once we upgrade to latest, eg. #6821

@philknows philknows added scope-testing Issues for adding test coverage, fixing existing tests or testing strategies. spec-electra 🦒 Issues targeting the Electra spec version labels Jan 13, 2025
@nflaig nflaig mentioned this issue Jan 15, 2025
Merged
@nflaig
Copy link
Member

nflaig commented Jan 15, 2025

Resolved by #7364

@nflaig nflaig closed this as completed Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope-testing Issues for adding test coverage, fixing existing tests or testing strategies. spec-electra 🦒 Issues targeting the Electra spec version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ensi321 @nflaig @philknows