Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't tests use "stark" theme now? #173

Open
JPustkuchen opened this issue Jun 4, 2024 · 1 comment
Open

Shouldn't tests use "stark" theme now? #173

JPustkuchen opened this issue Jun 4, 2024 · 1 comment

Comments

@JPustkuchen
Copy link

JPustkuchen commented Jun 4, 2024

Just saw that drush gen test:webdriver uses protected $defaultTheme = 'claro';:

protected $defaultTheme = 'claro';

Is that correct? Or isn't that the proposed base theme for webdriver tests? Perhaps I'm missing something?

I guess we should change this to the "stark" theme?

See:

I sadly couldn't find clear documentation or a change record pointing this out safe.

@Chi-teck
Copy link
Owner

Chi-teck commented Jun 8, 2024

I don't know if there is a "proposed" theme for tests. I personally prefer Claro as it has more convenient selectors in markup. However, given Drupal core and contrib modules mostly use Stark we might consider using Stark in DCG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants