Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve performance of sequence #3

Open
ChrisCavs opened this issue May 23, 2023 · 1 comment
Open

improve performance of sequence #3

ChrisCavs opened this issue May 23, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request nice to have
Milestone

Comments

@ChrisCavs
Copy link
Owner

sequence relies on repeated copying of the array. according to vore from HN:

You could get a vast performance improvement by copying the input array and running the standard Fisher–Yates shuffle over it

@ChrisCavs ChrisCavs added the enhancement New feature or request label May 23, 2023
@ChrisCavs ChrisCavs self-assigned this May 23, 2023
@ChrisCavs ChrisCavs added this to the v1.1.0 milestone May 23, 2023
@ChrisCavs ChrisCavs modified the milestones: v1.1.0, v1.0.3 Jun 2, 2023
@ChrisCavs
Copy link
Owner Author

in order to preserve the functionality of custom engines, i will need to keep the sequence function as-is. However, I can add a fisherSequence function.

@ChrisCavs ChrisCavs modified the milestones: v1.0.3, v1.1.0 Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request nice to have
Projects
None yet
Development

No branches or pull requests

1 participant