-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mybash deps check is bugged #750
Comments
/label 'script' |
you're wrong, the ! means if even all are installed it will still install, same for if none are found or if only 1 / 2 are found can not reproduce this issue as well. there is really no issue here |
It is an issue, it's reproducible using both openSUSE and Kali |
|
read what i said please |
@nnyyxxxx I don't understand why all of my contributions have been met with such fierce criticism on your part. You're free to say that I'm wrong, but the fundamental issue still remains, regardless. |
i cant reproduce the issue you're having man... all that PR is doing is bloating up the func, if you want a clear-cut solution to your nonexistent problem then remove every other dep from the command_exists var |
Ok, close the issue then, if you're insisting that there's no issue |
These are the exact steps to reproduce:
|
Describe the bug
mybash-setup.sh
usescommand_exists "bash" "bash-completion" ...
as if it fails if one of the dependencies does not exist, but this won't work as written. Also,bash-completion
andfontconfig
aren't executables, so the check would always fail if it did work as intended...To Reproduce
Screenshots
If applicable, add screenshots to help explain your problem.
Checklist
The text was updated successfully, but these errors were encountered: