Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhpBrowser _closeSession doesn't close session. #9

Open
Naktibalda opened this issue Jul 7, 2016 · 0 comments
Open

PhpBrowser _closeSession doesn't close session. #9

Naktibalda opened this issue Jul 7, 2016 · 0 comments

Comments

@Naktibalda
Copy link
Member

https://github.com/Codeception/Codeception/blob/2.2.2/src/Codeception/Module/PhpBrowser.php#L279

    public function _closeSession($session)
    {
        unset($session);
    }

All _closeSession does is unsetting a local variable.
To achieve desired effect, $session would have to be passed by reference and value overwritten instead of unsetting.

The only place where this method is called is https://github.com/Codeception/Codeception/blob/2.2.2/src/Codeception/Lib/Friend.php#L70

Update: _backupSession is fine.

@Naktibalda Naktibalda changed the title PhpBrowser MultiSession functionality looks bad PhpBrowser _closeSession doesn't close session. Jul 7, 2016
@Naktibalda Naktibalda transferred this issue from Codeception/Codeception Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant